[Marble-devel] Review Request: GSoC2012 Vector tile rendering. All the remaining code changes needed.

Fri Nov 23 10:33:34 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106013/
-----------------------------------------------------------

(Updated Nov. 23, 2012, 10:33 a.m.)

Review request for Marble.

Changes
-------

Diff updated

Description
-------

More documentation can be found here: http://techbase.kde.org/Projects/Marble/GSoC2012

Review Request #106009 needs to be previously submitted, for this to work.

During this GSoC2012 n order to make Marble download, render and manage vector data tiles, some classes have been created. The download url written in the .dgml file will download the tiles according to OpenStreetMaps tile names and it will try to parse them with all Marble's parsers. This GSoC tests have been made with the .dgml file included in this review and Kothic's server json tiles (hosted on http://osmosnimki.ru/vtile/ - please don't use it heavily-loaded projects for now) while OpenStreetMap finishes building its own data tile server. These Kothic tiles have a very similar format (https://github.com/kothic/kothic-js/wiki/Tiles-format) to the ones that OSM will have.

When Vector data is parsed it is stacked in an abstract class Tile (which is extended by ImageTile or VectorTile depending on the map) and is sent to VectorTileLayer which renders it.

Diffs (updated)
-----

  data/CMakeLists.txt abea001 
  data/maps/earth/vectorosm/0/0/0.jpeg PRE-CREATION 
  data/maps/earth/vectorosm/0/0/0.js PRE-CREATION 
  data/maps/earth/vectorosm/0/0/0.png PRE-CREATION 
  data/maps/earth/vectorosm/legend.html PRE-CREATION 
  data/maps/earth/vectorosm/legend/airportapron.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/airportrunway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/boundary.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/bridge.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/bridleway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/byway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/cycleway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/footway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/motorway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/primaryroad.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/railway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/railwaystation.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/secondaryroad.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/significantbuilding.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/subway.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/summitpeak.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/track.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/tram.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/trunkroad.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/tunnel.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/unclassifiedroad.png PRE-CREATION 
  data/maps/earth/vectorosm/legend/unsurfacedroad.png PRE-CREATION 
  data/maps/earth/vectorosm/srtm.jpg PRE-CREATION 
  data/maps/earth/vectorosm/vectorosm-preview.png PRE-CREATION 
  data/maps/earth/vectorosm/vectorosm.dgml PRE-CREATION 
  src/lib/CMakeLists.txt 9e27a31 
  src/lib/DownloadRegionDialog.cpp a67c7aa 
  src/lib/ElevationModel.h 69f7e6a 
  src/lib/ElevationModel.cpp f1d52a6 
  src/lib/FileStoragePolicy.cpp 6a505b7 
  src/lib/FileStorageWatcher.cpp 27c5dae 
  src/lib/GeoDataTreeModel.cpp 7c5649d 
  src/lib/GeoPainter.cpp f57a3ca 
  src/lib/MarbleMap.cpp 601e3f6 
  src/lib/MarbleModel.cpp 5f3f217 
  src/lib/MarbleRunnerManager.cpp ffa7a31 
  src/lib/MergedLayerDecorator.h 844a4fa 
  src/lib/MergedLayerDecorator.cpp 5b48ad1 
  src/lib/ScanlineTextureMapperContext.h c71c892 
  src/lib/ScanlineTextureMapperContext.cpp ff3197b 
  src/lib/ServerLayout.cpp b9a39b1 
  src/lib/SphericalScanlineTextureMapper.cpp 0d6bb93 
  src/lib/StackedTile.h aac0126 
  src/lib/StackedTile.cpp a230b62 
  src/lib/StackedTileLoader.h 4f8be0b 
  src/lib/StackedTileLoader.cpp 796c8c0 
  src/lib/StackedTile_p.h 2e6188c 
  src/lib/TextureTile.h bf6e33f 
  src/lib/TextureTile.cpp 97bae36 
  src/lib/Tile.h PRE-CREATION 
  src/lib/Tile.cpp PRE-CREATION 
  src/lib/TileLoader.h 7fd461e 
  src/lib/TileLoader.cpp a796754 
  src/lib/TileScalingTextureMapper.cpp f5770b6 
  src/lib/VectorTile.h PRE-CREATION 
  src/lib/VectorTile.cpp PRE-CREATION 
  src/lib/VectorTileMapper.h PRE-CREATION 
  src/lib/VectorTileMapper.cpp PRE-CREATION 
  src/lib/blendings/Blending.h ae56e7a 
  src/lib/blendings/BlendingAlgorithms.h 49d3206 
  src/lib/blendings/BlendingAlgorithms.cpp 07ce60e 
  src/lib/blendings/SunLightBlending.h 6628d22 
  src/lib/blendings/SunLightBlending.cpp 6f2f8fb 
  src/lib/geodata/data/GeoDataContainer.cpp bdd8fa0 
  src/lib/geodata/data/GeoDataContainer_p.h b3a3872 
  src/lib/geodata/data/GeoDataFeature.cpp 579bcf7 
  src/lib/geodata/data/GeoDataLatLonAltBox.h 6432a64 
  src/lib/geodata/handlers/dgml/DgmlDownloadPolicyTagHandler.cpp 2231694 
  src/lib/geodata/scene/GeoSceneMap.cpp ffa2006 
  src/lib/geodata/scene/GeoSceneTiled.h 3fe433c 
  src/lib/geodata/scene/GeoSceneTiled.cpp 84c84e0 
  src/lib/geodata/writers/dgml/DgmlTextureTagWriter.cpp d86423c 
  src/lib/layers/CMakeLists.txt 5506812 
  src/lib/layers/GeometryLayer.cpp 5f51dfa 
  src/lib/layers/TextureLayer.h 5db2970 
  src/lib/layers/TextureLayer.cpp 0eb56d9 
  src/lib/layers/VectorTileLayer.h PRE-CREATION 
  src/lib/layers/VectorTileLayer.cpp PRE-CREATION 
  src/marble_part.cpp 3769afb 
  tests/TestGeoSceneWriter.cpp 0b1fbe7 

Diff: http://git.reviewboard.kde.org/r/106013/diff/

Testing
-------

Testing done with the .dgml and the files attached.

Thanks,

Ander Pijoan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121123/c9601ec9/attachment.html>