[Marble-devel] Review Request: GPX improvements

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103672/#review21464
-----------------------------------------------------------

Ship it!


Looks good and works fine with all the .gpx files I tested.



src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h
<http://git.reviewboard.kde.org/r/103672/#comment16691>

    Can you use the shorter copyright header in all new files, please? Like so
    
    //
    // This file is part of the Marble Virtual Globe.
    //
    // This program is free software licensed under the GNU LGPL. You can
    // find a copy of this license in LICENSE.txt in the top directory of
    // the source code.
    //
    // Copyright 2012 Anders Lund <anders at alweb.dk>
    //
    



src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h
<http://git.reviewboard.kde.org/r/103672/#comment16692>

    Should be you instead, no?



src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp
<http://git.reviewboard.kde.org/r/103672/#comment16693>

    Should be you instead, no?



src/plugins/runner/gpx/handlers/GPXurlTagHandler.cpp
<http://git.reviewboard.kde.org/r/103672/#comment16694>

    Does this have an effect?
    


- Dennis Nienhüser


On Nov. 5, 2012, 9 a.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103672/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2012, 9 a.m.)
> 
> 
> Review request for Marble, Torsten Rahn and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> GPX improvements, without sym (icon) handling
> This patch
> * makes route handling simpler, just displays a blue (oxygen color) linestring
> * handles type, cmt, desc, link (GPX 1.19 and url (GPX 1.0)
>   - links are added to the description, and http url handling is turned on in the infodialog description view
>   - cmt is used as display name where present. The rationale is that this is what it is meant for: it is a field for a user friendly name of a waypoint for small gps devices with very small screens.
>   - desc is shown in the information dialog
>  
> 
> 
> Diffs
> -----
> 
>   src/lib/PlacemarkInfoDialog.cpp e9889ee5bd609c8e1aaed66aed0a22e437ae8b14 
>   src/plugins/runner/gpx/CMakeLists.txt bee89acc8bf899022c692474b297a5f15c615411 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.h cce7476d5ac411271e8961a61334a7496e38da13 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 2f9f2d096cf4aa191a341d89e1cf65c1dd4f60cb 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp d3f9d1001b3d18a51b853b77a783e4502ea6f31b 
>   src/plugins/runner/gpx/handlers/GPXlinkTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXlinkTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXnameTagHandler.cpp 400c9c89d1b1c4b0b52d9120c2161d20c6f4b46a 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp 022744d58719e6a95f02865a91e0906c6a25d8cf 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h c5b420a713922d1f425013364d66072b75f498fc 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp 994fcbf473b131afb815b9b308ac48138de7f2b7 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b7efbe4d01c486e7a460202d181412a74f730684 
> 
> Diff: http://git.reviewboard.kde.org/r/103672/diff/
> 
> 
> Testing
> -------
> 
> I have used this quite a bit, and of cause verified that it compiles.
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121105/e2f4612c/attachment.html>