[Marble-devel] Review Request: Clear search results when switching theme

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107182/#review21402
-----------------------------------------------------------


Code looks fine. I wonder whether clearing the results should be restricted to a change of the celestial body: When switching from e.g. satellite view to OSM, I'd rather have the search results stay. That behavior would be consistent with what Google Maps does.

- Dennis Nienhüser


On Nov. 2, 2012, 8:04 p.m., René Küttner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107182/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2012, 8:04 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> With this patch applied, search results and the search result cache are
> cleared when a new theme (a new planet or map) is selected.
> 
> Currently, if you search for a placemark, hit enter and select it in
> the navigation widget, it remains in place when the theme is switched.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleControlBox.cpp 66bbbde 
>   src/lib/NavigationWidget.h f28e892 
>   src/lib/NavigationWidget.cpp 1dac315 
> 
> Diff: http://git.reviewboard.kde.org/r/107182/diff/
> 
> 
> Testing
> -------
> 
> Tested against master with Qt-only and kde build.
> 
> 
> Thanks,
> 
> René Küttner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121104/aecb6350/attachment.html>