[Marble-devel] Review Request: Fix painting of polygons with holes

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105019/#review14076
-----------------------------------------------------------

Ship it!


Interesting. I thought I tested the code with some case like this but my memories might trick me. Or it's indeed a regression of Qt / QPathClipper / QPainter. I mean why shouldn't the original code work? :) But this workaround should be fine. I think in terms of performance it's also not slower since the same kind of thing (paint filling first, then the outline) is probably done inside Qt as well.

- Torsten Rahn


On May 23, 2012, 7:54 a.m., Dennis Nienhüser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105019/
> -----------------------------------------------------------
> 
> (Updated May 23, 2012, 7:54 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Currently GeoPainter renders Polygons wrong if they have an outline pen and are filled (think of buildings): A QPolygonF is created from the outer boundary and the inner rings are subtracted. Now QPainter paints the stroke of such Polygons by connecting each point, leading to unwanted connections between the outer boundary and the inner holes. See http://i.imgur.com/25rjs.png (from Ander).
> 
> The patch changes this to paint the background (brush) as previous, but paints the outer and inner rings' outlines individually. Please review with performance in mind. Any ideas how to paint everything in one go (should be faster)?
> 
> 
> Diffs
> -----
> 
>   src/lib/GeoPainter.cpp aa18e47 
> 
> Diff: http://git.reviewboard.kde.org/r/105019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis Nienhüser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120523/f832cfa6/attachment.html>