[Marble-devel] Review Request: First version of flightgear position provider plugin

[Dennis Nienhüser]

> On April 30, 2012, 3:09 p.m., Dennis Nienhüser wrote:
> > cmake/modules/Findnmealib.cmake, line 4
> > <http://git.reviewboard.kde.org/r/104736/diff/3/?file=58669#file58669line4>
> >
> >     For consistency I'd strip the lib postfix everywhere, i.e. use Findnmea.cmake, NMEA_FOUND, ...
> >
> 
> Ralf Habacker wrote:
>     consistency to what ? there are Findlibgps.cmake using a lib prefix and some without any prefix or postfix. The original project on sf used nmealib.
> 
> Ralf Habacker wrote:
>     one more inconsistence 
>     
>     http://nienhueser.de/marble/libnmea/ 
>     nmealib-dev_0.5.3_i386.deb
>

The lib prefix is often used in Debian packages, and libraries in Linux are nearly all named like lib$foo.$ext. A lib postfix sounds redundant to me though, but I don't have a strong opinion on it.


> On April 30, 2012, 3:09 p.m., Dennis Nienhüser wrote:
> > src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp, line 144
> > <http://git.reviewboard.kde.org/r/104736/diff/3/?file=58673#file58673line144>
> >
> >     I read this as #ifndef NMEA_TUD_FEED being a version check for nmealib <= 0.5.3.
> >     
> >     Wouldn't the following work as well?
> >     
> >     qreal elevation = m_info.elv;
> >     #ifndef NMEA_TUD_FEED
> >     elevation *= 0.3048;
> >     #endif
> >     
> >     The advantage is that you don't create a "foreign" #define
> >
> 
> Ralf Habacker wrote:
>     > I read this as #ifndef NMEA_TUD_FEED being a version check for nmealib <= 0.5.3.
>     yes, because nmealib do not have a dedicated version macro. 
>     
>     > The advantage is that you don't create a "foreign" #define
>     what about moving this hack completly to nmealib ?  I added a related patch at
>     https://projects.kde.org/projects/kdesupport/emerge/repository/revisions/master/changes/portage/win32libs-sources/nmealib-src/0009-feet-unit-elevation-fix.patch
>     
>

That'd be even better of course. Is the project still active? IIRC the last commit to their sourceforge repository was about four years ago.


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104736/#review13077
-----------------------------------------------------------


On May 3, 2012, 9:57 a.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104736/
> -----------------------------------------------------------
> 
> (Updated May 3, 2012, 9:57 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> When selecting the plugin in the current location panel it starts listen on an udp socket (localhost:5500), which is the default port flightgear uses for exporting map display information. The data send to this port is build as gps data in nmea format.
> 
> The plugin depends on the mnea library http://nmea.sourceforge.net/. The presence of this library is checked on configure time. Building of this plugins only happens when this library is available. 
> 
> On windows the nmea library has been added to the KDE on windows build enviroment. 
> 
> 
> This addresses bug 298785.
>     http://bugs.kde.org/show_bug.cgi?id=298785
> 
> 
> Diffs
> -----
> 
>   Findnmealib.cmake PRE-CREATION 
>   src/plugins/positionprovider/CMakeLists.txt bebe774 
>   src/plugins/positionprovider/flightgear/CMakeLists.txt PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.h PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104736/diff/
> 
> 
> Testing
> -------
> 
> succesfull build and tested on windows 7 with msvc 2010 in debug and release mode
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120503/d1beebab/attachment.html>