[Marble-devel] Review Request: First version of flightgear position provider plugin
Ralf Habacker
ralf.habacker at gmail.com
Thu May 3 08:55:20 UTC 2012
> On April 30, 2012, 3:09 p.m., Dennis Nienhüser wrote:
> > cmake/modules/Findnmealib.cmake, line 4
> > <http://git.reviewboard.kde.org/r/104736/diff/3/?file=58669#file58669line4>
> >
> > For consistency I'd strip the lib postfix everywhere, i.e. use Findnmea.cmake, NMEA_FOUND, ...
> >
>
> Ralf Habacker wrote:
> consistency to what ? there are Findlibgps.cmake using a lib prefix and some without any prefix or postfix. The original project on sf used nmealib.
one more inconsistence
http://nienhueser.de/marble/libnmea/
nmealib-dev_0.5.3_i386.deb
- Ralf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104736/#review13077
-----------------------------------------------------------
On April 27, 2012, 6:27 a.m., Ralf Habacker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104736/
> -----------------------------------------------------------
>
> (Updated April 27, 2012, 6:27 a.m.)
>
>
> Review request for Marble.
>
>
> Description
> -------
>
> When selecting the plugin in the current location panel it starts listen on an udp socket (localhost:5500), which is the default port flightgear uses for exporting map display information. The data send to this port is build as gps data in nmea format.
>
> The plugin depends on the mnea library http://nmea.sourceforge.net/. The presence of this library is checked on configure time. Building of this plugins only happens when this library is available.
>
> On windows the nmea library has been added to the KDE on windows build enviroment.
>
>
> This addresses bug 298785.
> http://bugs.kde.org/show_bug.cgi?id=298785
>
>
> Diffs
> -----
>
> CMakeLists.txt d6466aa
> cmake/modules/Findnmealib.cmake PRE-CREATION
> src/plugins/positionprovider/CMakeLists.txt bebe774
> src/plugins/positionprovider/flightgear/CMakeLists.txt PRE-CREATION
> src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.h PRE-CREATION
> src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/104736/diff/
>
>
> Testing
> -------
>
> succesfull build and tested on windows 7 with msvc 2010 in debug and release mode
>
>
> Thanks,
>
> Ralf Habacker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120503/e00c0dd6/attachment.html>
More information about the Marble-devel
mailing list