[Marble-devel] Review Request: AbstractProjection: bring dateline issue as a projection topic

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104175/#review11316
-----------------------------------------------------------


Disclaimer: I'm not very familiar with the problem the patch tries to solve. At a first glance, though, dealing with dateline issues in the projections seems like the right approach to me.

Just by looking at the amount of qDebug() statements, I wonder if another programmer gets a clou from the tests if he (accidently) made them fail? Are the tests detailed enough to catch common mistakes even w/o looking at the debug output (and interpret it properly)?

IMO, either the tests should be more detailed to catch improper modifications automatically, or the debug statements should be removed.

- Bernhard Beschow


On March 6, 2012, 7:27 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104175/
> -----------------------------------------------------------
> 
> (Updated March 6, 2012, 7:27 p.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Description
> -------
> 
> Try to separate concerns between Geo coordinates and screen coordinates.
> IDL is supposed to be an issue for those projections which have repeatable X property.
> As a first attempt, the patch brings IDL calculation into the abstract projection.
> Next step is to move horizon and pole for spherical algo, and idl for flat maps.
> 
> 
> Diffs
> -----
> 
>   src/lib/Projections/AbstractProjection.cpp edac2a7 
>   src/lib/Projections/AbstractProjection_p.h a93ab13 
>   src/lib/geodata/data/GeoDataLineString.cpp b459dd8 
>   tests/CMakeLists.txt 8e80456 
>   tests/ProjectionTest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104175/diff/
> 
> 
> Testing
> -------
> 
> Projection test tries to handle the 3 tessellation modes across IDL functional cases onto some projections.
> Tests are generic enough to catch easy to break regressions.
> More tests for Horizon, pole, visibility and projection welcome!
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120312/f2ff95b1/attachment.html>