[Marble-devel] Review Request: Task 3 from Trello: separate IDL, poles and lineStringToPolygon into CylindricalProjections

Cezar Mocan mocancezar at gmail.com
Sat Jun 16 12:06:53 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated June 16, 2012, 12:06 p.m.)

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.


Updated the diff. 


Separate AbstractProjectionPrivate::lineStringToPolygon into CylindricalProjectionPrivate::lineStringToPolygon and SphericalProjectionPrivate::lineStringToPolygon in order to get rid of the corner cases. 
It is not final, right now I have just commented the lines which need to be removed in my opinion. Also, I would need some advice regarding what else needs to be deleted from CylindricalProjectionPrivate::lineStringToPolygon. 

Diffs (updated)

  src/lib/Projections/AbstractProjection_p.h d8f6063 
  src/lib/Projections/CylindricalProjection.h affd1e6 
  src/lib/Projections/CylindricalProjection.cpp c103a68 
  src/lib/Projections/AbstractProjection.cpp 92ae3dd 
  src/lib/Projections/CylindricalProjection_p.h PRE-CREATION 
  src/lib/Projections/SphericalProjection.h 75ea797 
  src/lib/Projections/SphericalProjection.cpp 0978af4 
  src/lib/Projections/SphericalProjection_p.h PRE-CREATION 
  src/lib/Projections/provisionalPatch.diff 958d079 

Diff: http://git.reviewboard.kde.org/r/105261/diff/


Marble seems to work properly with all 3 projections after applying the patch. MercatorProjectionTest passes all the 5 tests. How else could I test the change?


Cezar Mocan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120616/6077c005/attachment.html>

More information about the Marble-devel mailing list