[Marble-devel] Review Request: Task 3 from Trello: separate IDL, poles and lineStringToPolygon into CylindricalProjections
Cezar Mocan
mocancezar at gmail.com
Fri Jun 15 10:46:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105261/
-----------------------------------------------------------
(Updated June 15, 2012, 10:46 a.m.)
Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
Description (updated)
-------
Separate AbstractProjectionPrivate::lineStringToPolygon into CylindricalProjectionPrivate::lineStringToPolygon and SphericalProjectionPrivate::lineStringToPolygon in order to get rid of the corner cases.
It is not final, right now I have just commented the lines which need to be removed in my opinion. Also, I would need some advice regarding what else needs to be deleted from CylindricalProjectionPrivate::lineStringToPolygon.
Diffs
-----
src/lib/Projections/AbstractProjection_p.h d8f6063
src/lib/Projections/CylindricalProjection.h affd1e6
src/lib/Projections/CylindricalProjection.cpp c103a68
src/lib/Projections/CylindricalProjection_p.h PRE-CREATION
src/lib/Projections/SphericalProjection.h 75ea797
src/lib/Projections/SphericalProjection.cpp 0978af4
src/lib/Projections/SphericalProjection_p.h PRE-CREATION
src/lib/Projections/provisionalPatch.diff 958d079
Diff: http://git.reviewboard.kde.org/r/105261/diff/
Testing
-------
Marble seems to work properly with all 3 projections after applying the patch, how else could I test them?
Thanks,
Cezar Mocan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120615/224a5652/attachment.html>
More information about the Marble-devel
mailing list