[Marble-devel] Review Request: don't paint default background for OSM vector data

Bernhard Beschow bbeschow at cs.tu-berlin.de
Thu Jun 14 19:17:11 UTC 2012

This is an automatically generated e-mail. To reply, visit:

Review request for Marble.


== Motivation ==
The default background has always the same color, regardless of wheter it covers sea or land mass. As a result, information from the underlying (base) layer gets hidden, e.g. satellite imagery. By not painting a default background, information is preserved for areas where no OSM data is available, while allowing any map theme to be enriched by OSM vector data.

In addition, this patch assigns a bbox to the GeoDataDocument. Please check whether this is done correctly.


  src/plugins/runner/osm/handlers/OsmBoundsTagHandler.cpp fc828e0da13dcb592ddbc17451efede56a9181e2 

Diff: http://git.reviewboard.kde.org/r/105253/diff/


No background is painted, as intended. However, the area is still zoomed out too far when the .osm file has finished loading.


Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120614/8bdeee84/attachment.html>

More information about the Marble-devel mailing list