[Marble-devel] Review Request: Turn PlacemarkPainter into PlacemarkLayer, reverse composition with PlacemarkLayout

[Bernhard Beschow]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105152/
-----------------------------------------------------------

Review request for Marble.


Description
-------

PlacemarkLayout used to be both responsible for laying out placemarks and painting them. After having determined the layout, it realized painting by delegating the acutal work to PlacemarkPainter.

By reversing composition, PlacemarkPainter would ask PlacemarkLayout to update the layout before it would paint the placemarks itself. That way, PlacemarkPainter becomes a layer and PlacemarkLayout would be the layer's model, which is a common pattern in Marble.


Diffs
-----

  src/lib/CMakeLists.txt 1208f5fed336d78723090269bb631285361dcb56 
  src/lib/MarbleMap.cpp 73a56fce591f51a89a83b5db65ed6b9b56bc0a13 
  src/lib/PlacemarkLayout.h PRE-CREATION 
  src/lib/PlacemarkLayout.cpp PRE-CREATION 
  src/lib/PlacemarkPainter.h 9e3d2aa913d4452dcec4f0dc6e01a9252d90e058 
  src/lib/PlacemarkPainter.cpp 2ca9fa7b0044cd672db711919f3a6c88f3c1eb83 
  src/lib/layers/CMakeLists.txt 460d9fbe29627253383485566cfae02e362e1459 
  src/lib/layers/PlacemarkLayer.h PRE-CREATION 
  src/lib/layers/PlacemarkLayer.cpp PRE-CREATION 
  src/lib/layers/PlacemarkLayout.h cfad7f7ea27854bfcbe00100d4905604e5add954 
  src/lib/layers/PlacemarkLayout.cpp e28ad242d2368f09476b41fafb3008119f0a70c7 

Diff: http://git.reviewboard.kde.org/r/105152/diff/


Testing
-------

Tested with Atlas theme; Cities seem to be rendered like before.


Thanks,

Bernhard Beschow

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120605/cde040de/attachment.html>