[Marble-devel] Review Request: Perform local searches

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105772/#review16635
-----------------------------------------------------------



src/lib/MarbleAbstractRunner.h
<http://git.reviewboard.kde.org/r/105772/#comment12978>

    Why no reference? :)



src/lib/NavigationWidget.cpp
<http://git.reviewboard.kde.org/r/105772/#comment12980>

    I feel this should be named "setBoundedSearchEnabled" to be consistent with Qt APIs.



src/lib/NavigationWidget.ui
<http://git.reviewboard.kde.org/r/105772/#comment12979>

    Not sure about the name, the default value and about the way this is presented in the UI.


- Torsten Rahn


On July 28, 2012, 4:34 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105772/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 4:34 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> I collapsed many commits together so that it forms only one review, so I'll describe more:
> 
> - first part changes the api for SearchRunner, adding a LatLonAltBox parameter. This impacts all search runners in consequence, but not all will provide the functionality.
> - nominatim-search adds the &viewbox= parameters to uri, performing a restrained search
> - local-osm-search takes into account the center of that bbox and sorts the results by proximity.
> - localdatabase filters the results based on that bbox.
> 
> MarbleRunnerManager needs to change its caching such that asking the same searchTerm on another bbox triggers a new search.
> Last, the NavigationWidget enables that Local search through a checkbox, as I couldn't find easy way to decide if a search could be local or not from the searchTerm only.
> 
> Ideas for future:
> Perform local search by default might be the way to go, and asking for a general search a second class citizen.
> local-osm-search has quite advanced analysis of search, maybe bringing this to main would benefit others.
> Sorting by distance or by relevance is undecided as well.
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleAbstractRunner.h f3d9665 
>   src/lib/MarbleAbstractRunner.cpp 9e14e37 
>   src/lib/MarbleRunnerManager.h 88153df 
>   src/lib/MarbleRunnerManager.cpp 8e0589d 
>   src/lib/NavigationWidget.h 1b509f5 
>   src/lib/NavigationWidget.cpp 706daa1 
>   src/lib/NavigationWidget.ui 4c259a6 
>   src/lib/RunnerTask.h eafd719 
>   src/lib/RunnerTask.cpp 2bb020a 
>   src/plugins/runner/hostip/HostipRunner.h ca2c745 
>   src/plugins/runner/hostip/HostipRunner.cpp 6b161ba 
>   src/plugins/runner/latlon/LatLonRunner.h a7b16bf 
>   src/plugins/runner/latlon/LatLonRunner.cpp 73b23b7 
>   src/plugins/runner/local-osm-search/DatabaseQuery.h ec00d97 
>   src/plugins/runner/local-osm-search/DatabaseQuery.cpp 87c6b0f 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.h 1795494 
>   src/plugins/runner/local-osm-search/LocalOsmSearchRunner.cpp 9a82e80 
>   src/plugins/runner/local-osm-search/OsmDatabase.h 10c7beb 
>   src/plugins/runner/local-osm-search/OsmDatabase.cpp 477708a 
>   src/plugins/runner/localdatabase/LocalDatabaseRunner.h 034919b 
>   src/plugins/runner/localdatabase/LocalDatabaseRunner.cpp 7d469bb 
>   src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.h d8337a8 
>   src/plugins/runner/nominatim-search/OsmNominatimSearchRunner.cpp 1345dfa 
> 
> Diff: http://git.reviewboard.kde.org/r/105772/diff/
> 
> 
> Testing
> -------
> 
> Searching by poi terms now brings interesting results.
> Unchecking still allows to search for the numerous city homonyms, and specific adress still works in both cases.
> Other search usecases unaffected: routing still performs unboxed search.
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120730/b921be36/attachment-0001.html>