[Marble-devel] Review Request: DGML maps created not only from PNT and KML, but from every Marble compatible format (SHP and others)

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105670/#review16210
-----------------------------------------------------------



src/lib/layers/GroundLayer.h
<http://git.reviewboard.kde.org/r/105670/#comment12771>

    You're the only copyright holder for this file, please remove the others.



src/lib/layers/GroundLayer.h
<http://git.reviewboard.kde.org/r/105670/#comment12776>

    Please use <QtGui/QColor>



src/lib/layers/GroundLayer.h
<http://git.reviewboard.kde.org/r/105670/#comment12775>

    The comment seems wrong, the variable cannot be set from outside and is not changed inside the implementation.



src/lib/layers/GroundLayer.cpp
<http://git.reviewboard.kde.org/r/105670/#comment12772>

    I'd say you should be the only copyright holder here as well.



src/lib/layers/GroundLayer.cpp
<http://git.reviewboard.kde.org/r/105670/#comment12773>

    Not needed



src/lib/layers/GroundLayer.cpp
<http://git.reviewboard.kde.org/r/105670/#comment12774>

    Code style suggests to use curly brackets also for one-liners.


- Dennis Nienhüser


On July 22, 2012, 4:49 p.m., Cezar Mocan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105670/
> -----------------------------------------------------------
> 
> (Updated July 22, 2012, 4:49 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser, Torsten Rahn, and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> Now it's possible to create a DGML map from any kind of file that can be rendered by Marble. 
> Also, I added a groundLayer whose color can be specified from the DGML file via the <map bgcolor=""> tag. 
> The groundLayer gets displayed only if the DGML map theme doesn't have texture layers. 
> (all the changes are towards the big step of removing the PNT files from Marble)
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMap.cpp 7ad1c6e 
>   src/lib/MarbleModel.cpp 3624ad3 
>   src/lib/layers/CMakeLists.txt 69aa194 
>   src/lib/layers/GroundLayer.h PRE-CREATION 
>   src/lib/layers/GroundLayer.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Cezar Mocan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120722/8483ba63/attachment-0001.html>