[Marble-devel] Review Request: dynamic label number based on screen ratio

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103813/#review10241
-----------------------------------------------------------

Ship it!


Some minor stuff below.


src/lib/layers/PlacemarkLayout.h
<http://git.reviewboard.kde.org/r/103813/#comment8436>

    For code readability I'd prefer something like
    
    bool exceedsMaximumDensity( int labelArea, int screenArea )
    
    and pass m_labelArea and screenSize.width() * screenSize.height() to it.
    



src/lib/layers/PlacemarkLayout.h
<http://git.reviewboard.kde.org/r/103813/#comment8437>

    I'd prefer an initialization to 0 in the ctor just to be sure.
    



src/lib/layers/PlacemarkLayout.cpp
<http://git.reviewboard.kde.org/r/103813/#comment8439>

    When/where is this visible? Looks like debug statistics to me. If it stays in, maybe add a comment for the translators that the string needs no tr().


- Dennis Nienhüser


On Jan. 28, 2012, 4:30 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103813/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 4:30 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Shift from a hard 100 number of labels to a label area ratio of available screen.
> 
> 
> Diffs
> -----
> 
>   src/lib/layers/PlacemarkLayout.h e66c121 
>   src/lib/layers/PlacemarkLayout.cpp ae8d818 
> 
> Diff: http://git.reviewboard.kde.org/r/103813/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120130/53438db4/attachment.html>