[Marble-devel] Review Request: Use qPow instead of pow10 to fix the build on !Linux

Dennis Nienhüser earthwings at gentoo.org
Mon Jan 30 16:50:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103821/#review10239
-----------------------------------------------------------

Ship it!


Looks good, please commit.


src/lib/MarbleMath.h
<http://git.reviewboard.kde.org/r/103821/#comment8435>

    Should rather be in ElevationProfilePlotAxis.cpp.


- Dennis Nienhüser


On Jan. 29, 2012, 2:43 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103821/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2012, 2:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Commit 49a9180e096240b44772a9e3f279e63b115dd2ce has added a call to pow10(), which is a GNU extension present only in glibc. This causes the build to fail on all systems which don't use glibc (OS X, the BSDs and Windows).
> 
> This patch replaces the call to pow10() with a call to qPow().
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleMath.h aeaadea 
>   src/plugins/render/elevationprofile/ElevationProfilePlotAxis.cpp eec47fc 
> 
> Diff: http://git.reviewboard.kde.org/r/103821/diff/diff
> 
> 
> Testing
> -------
> 
> Marble now builds fine on FreeBSD again.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120130/6a6d92e6/attachment.html>


More information about the Marble-devel mailing list