[Marble-devel] Review Request: ElevationProfile: Refactoring

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103793/#review10165
-----------------------------------------------------------


This review has been submitted with commit 49a9180e096240b44772a9e3f279e63b115dd2ce by Florian Eßer to branch master.

- Commit Hook


On Jan. 25, 2012, 6:07 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103793/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2012, 6:07 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Refactoring of the ElevationProfile plugin code.
> * axis handling moved to a dedicated class, no more double-code for X and Y scale calculation
> * try to generate 'nicer' interval ticks, e.g. 42.5 instead of 42.444
> * "double click -> jump to location" now works in zoom mode, too
> * minor optical changes
> * shortened the "Elevation difference" text to not get cropped in Marble Touch
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/elevationprofile/CMakeLists.txt f6fb1f3 
>   src/plugins/render/elevationprofile/ElevationProfileFloatItem.h 16e5ea3 
>   src/plugins/render/elevationprofile/ElevationProfileFloatItem.cpp 15b8084 
>   src/plugins/render/elevationprofile/ElevationProfilePlotAxis.h PRE-CREATION 
>   src/plugins/render/elevationprofile/ElevationProfilePlotAxis.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103793/diff/diff
> 
> 
> Testing
> -------
> 
> not yet tested for imperial units
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120128/a1c700fd/attachment.html>