[Marble-devel] Review Request: Experimenting flicker solutions

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103777/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Description
-------

This patch uses qreal for label collision detection, as screenCoordinates provides this precision.
This removes a lot of flicker due to truncating qreal to int.

Also provided (only for testing) is an indicator of the number of "available", "inside the viewport", "missed" labels due to roomForLabel in order to understand the reasons for flicker.


This addresses bug 288297.
    http://bugs.kde.org/show_bug.cgi?id=288297


Diffs
-----

  src/lib/PlacemarkPainter.cpp 509e5ed 
  src/lib/VisiblePlacemark.h 3382ee4 
  src/lib/VisiblePlacemark.cpp 9b88832 
  src/lib/layers/PlacemarkLayout.h b020dd1 
  src/lib/layers/PlacemarkLayout.cpp 7f66464 

Diff: http://git.reviewboard.kde.org/r/103777/diff/diff


Testing
-------

Removes already some nasty flickering in dense zones where truncating qreal is the main cause for flicker.
Next is deciding some more:
- changing orders of magnitude for placemarks (levelling off some dense zones),
- increasing the number of available placemarks (which has a big impact also on flickering in some regions)


Thanks,

Thibaut Gridel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120123/9c9a5a87/attachment.html>