[Marble-devel] Review Request: GPX improvements

[Niko Sams]

> On Jan. 11, 2012, 8:38 a.m., Niko Sams wrote:
> > I don't know if there is any policy or something on unit tests, but creating tests for this would be pretty easy.
> 
> Anders Lund wrote:
>     I have never tried to do that, so this could be the time.
>     I can look at the tests you did, I assume it involves parsing some data and verify it behaves as expected by testing the resulting GeoDataDocument?

yes, exactly.


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103672/#review9735
-----------------------------------------------------------


On Jan. 10, 2012, 9:17 p.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103672/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 9:17 p.m.)
> 
> 
> Review request for Marble, Torsten Rahn and Thibaut Gridel.
> 
> 
> Description
> -------
> 
> GPX improvements, without sym (icon) handling
> This patch
> * makes route handling simpler, just displays a blue (oxygen color) linestring
> * handles type, cmt, desc, link (GPX 1.19 and url (GPX 1.0)
>   - links are added to the description, and http url handling is turned on in the infodialog description view
>   - cmt is used as display name where present. The rationale is that this is what it is meant for: it is a field for a user friendly name of a waypoint for small gps devices with very small screens.
>   - desc is shown in the information dialog
>  
> 
> 
> Diffs
> -----
> 
>   src/lib/PlacemarkInfoDialog.cpp e9889ee 
>   src/plugins/runner/gpx/CMakeLists.txt bee89ac 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.h cce7476 
>   src/plugins/runner/gpx/handlers/GPXElementDictionary.cpp 2f9f2d0 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXcmtTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXdescTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp 14ea21f 
>   src/plugins/runner/gpx/handlers/GPXlinkTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXlinkTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXrteTagHandler.cpp 022744d 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.h c5b420a 
>   src/plugins/runner/gpx/handlers/GPXrteptTagHandler.cpp 994fcbf 
>   src/plugins/runner/gpx/handlers/GPXtextTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtextTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXtypeTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.h PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXurlnameTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/gpx/handlers/GPXwptTagHandler.cpp b7efbe4 
> 
> Diff: http://git.reviewboard.kde.org/r/103672/diff/diff
> 
> 
> Testing
> -------
> 
> I have used this quite a bit, and of cause verified that it compiles.
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120111/55cd1285/attachment.html>