[Marble-devel] Review Request: http://www.google-melange.com/gci/task/view/google/gci2011/7243204

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103653/#review9647
-----------------------------------------------------------


Should work, but I'd prefer storing a qreal (not QString) in GeoSceneHead (see comments).


src/lib/MarbleModel.cpp
<http://git.reviewboard.kde.org/r/103653/#comment7902>

    Please use > 0.0 (and a qreal in GeoSceneHead, see below)



src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h
<http://git.reviewboard.kde.org/r/103653/#comment7903>

    Please move it some lines up so that the list of attributes stays sorted



src/lib/geodata/handlers/dgml/DgmlTargetTagHandler.cpp
<http://git.reviewboard.kde.org/r/103653/#comment7906>

    The radius attribute should be optional in the .dgml and only set here if the string is non-empty and can be converted to a qreal



src/lib/geodata/scene/GeoSceneHead.cpp
<http://git.reviewboard.kde.org/r/103653/#comment7907>

    m_radius( 0.0 ) after changing to qreal. 0.0 can be used as a special value for default then.



src/lib/geodata/scene/GeoSceneHead.cpp
<http://git.reviewboard.kde.org/r/103653/#comment7904>

    Better use a qreal here



src/lib/geodata/scene/GeoSceneHead.cpp
<http://git.reviewboard.kde.org/r/103653/#comment7905>

    qreal (see above)


- Dennis Nienhüser


On Jan. 7, 2012, 6:43 p.m., Gábor Péterffy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103653/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 6:43 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> http://www.google-melange.com/gci/task/view/google/gci2011/7243204
> https://bugs.kde.org/show_bug.cgi?id=254286 -> fixed
> 
> 
> Diffs
> -----
> 
>   src/lib/MarbleModel.cpp 65f6dad 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h 04dff7c 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.cpp 354ec86 
>   src/lib/geodata/handlers/dgml/DgmlTargetTagHandler.cpp e0a7337 
>   src/lib/geodata/scene/GeoSceneHead.h 1a50d28 
>   src/lib/geodata/scene/GeoSceneHead.cpp 1cec1cc 
> 
> Diff: http://git.reviewboard.kde.org/r/103653/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gábor Péterffy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120108/88a643e5/attachment-0001.html>