[Marble-devel] Review Request: Fix floating items (un)locking state inconsistency

Paul Nader paul.nader at gmail.com
Wed Feb 22 23:33:31 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104017/
-----------------------------------------------------------

(Updated Feb. 22, 2012, 11:33 p.m.)


Review request for Marble and Bernhard Beschow.


Changes
-------

Added reviewer


Description
-------

This patch fixes an inconsistency in the marble application when locking floating items (e.g., compass, etc) through the main menu view->info boxes->lock position. If you unlock an item through its context menu and then lock all items through the main menu and then open again the item context menu it appears as unlocked even though it is locked. This patch updates all items menu contexts when the items are (un)locked through the main menu.


Diffs
-----

  src/lib/AbstractFloatItem.cpp 9de45b5 

Diff: http://git.reviewboard.kde.org/r/104017/diff/


Testing
-------

Unlock an item through its context menu and then lock all items through the main menu and then open again the item context menu. The item is shown as locked now.

Lock an item through its context menu and then unlock al items through the main menu and then open again the item context menu. The item is shown as unlocked now.


Thanks,

Paul Nader

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120222/40cab03b/attachment-0001.html>


More information about the Marble-devel mailing list