[Marble-devel] Review Request: Purge Download Queues when switching to offline

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103853/#review10298
-----------------------------------------------------------

Ship it!


Looks good.


src/lib/DownloadQueueSet.cpp
<http://git.reviewboard.kde.org/r/103853/#comment8484>

    I guess the queue needs to be cleared as well, qDeleteAll does not take care of that.



src/lib/HttpDownloadManager.cpp
<http://git.reviewboard.kde.org/r/103853/#comment8485>

    Please remove when committing.



src/lib/HttpDownloadManager.cpp
<http://git.reviewboard.kde.org/r/103853/#comment8486>

    pos->second is easier to read imho.


- Dennis Nienhüser


On Feb. 2, 2012, 8:48 p.m., Thibaut Gridel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103853/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2012, 8:48 p.m.)
> 
> 
> Review request for Marble and Bernhard Beschow.
> 
> 
> Description
> -------
> 
> Until now, switching to offline mode kept the download queues filled, meaning that really going offline would make 3 retries of all those download requests.
> This patch removes this, and cleans redundant list of current downloads from TileManager, as the DownloadManager simply discards tasks when offline anyway.
> 
> 
> Diffs
> -----
> 
>   src/lib/DownloadQueueSet.h 9d024f9 
>   src/lib/DownloadQueueSet.cpp ad4a777 
>   src/lib/HttpDownloadManager.cpp 262971f 
>   src/lib/TileLoader.h aef7e84 
>   src/lib/TileLoader.cpp e938bea 
> 
> Diff: http://git.reviewboard.kde.org/r/103853/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thibaut Gridel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120202/d49bc8b8/attachment.html>