[Marble-devel] Review Request: Migrate Weather Plugin to usage of MapInfoDialog

Illya Kovalevskyy illya.kovalevskyy at gmail.com
Sun Dec 30 10:24:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108021/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser, Torsten Rahn, and René Küttner.


Description
-------

Weather Plugin has been migrated to usage of MapInfoDialog successfully according to GCI task:
 - https://google-melange.appspot.com/gci/task/view/google/gci2012/8097206


Diffs
-----

  src/plugins/render/weather/AbstractWeatherService.h 8c8ce0e 
  src/plugins/render/weather/AbstractWeatherService.cpp 251fe4d 
  src/plugins/render/weather/BBCWeatherService.cpp 02898c1 
  src/plugins/render/weather/CMakeLists.txt 7b48dc9 
  src/plugins/render/weather/GeoNamesWeatherService.cpp 202a9c3 
  src/plugins/render/weather/WeatherItem.h 09829f9 
  src/plugins/render/weather/WeatherItem.cpp ae80079 
  src/plugins/render/weather/WeatherModel.h 7613b5f 
  src/plugins/render/weather/WeatherModel.cpp e6580d3 
  src/plugins/render/weather/WeatherPlugin.h 844f5b6 
  src/plugins/render/weather/WeatherPlugin.cpp dd5e3de 
  src/plugins/render/weather/data/marble_deco.png PRE-CREATION 
  src/plugins/render/weather/data/weather-clear-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-clear.png PRE-CREATION 
  src/plugins/render/weather/data/weather-clouds-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-clouds.png PRE-CREATION 
  src/plugins/render/weather/data/weather-few-clouds-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-few-clouds.png PRE-CREATION 
  src/plugins/render/weather/data/weather-freezing-rain.png PRE-CREATION 
  src/plugins/render/weather/data/weather-hail.png PRE-CREATION 
  src/plugins/render/weather/data/weather-many-clouds.png PRE-CREATION 
  src/plugins/render/weather/data/weather-mist.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers-day.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers-scattered-day.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers-scattered-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers-scattered.png PRE-CREATION 
  src/plugins/render/weather/data/weather-showers.png PRE-CREATION 
  src/plugins/render/weather/data/weather-snow-rain.png PRE-CREATION 
  src/plugins/render/weather/data/weather-snow-scattered-day.png PRE-CREATION 
  src/plugins/render/weather/data/weather-snow-scattered-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-snow-scattered.png PRE-CREATION 
  src/plugins/render/weather/data/weather-snow.png PRE-CREATION 
  src/plugins/render/weather/data/weather-storm-day.png PRE-CREATION 
  src/plugins/render/weather/data/weather-storm-night.png PRE-CREATION 
  src/plugins/render/weather/data/weather-storm.png PRE-CREATION 
  src/plugins/render/weather/data/weather.html PRE-CREATION 
  src/plugins/render/weather/data/weatherscreen.css PRE-CREATION 
  src/plugins/render/weather/weather.qrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/108021/diff/


Testing
-------

Built & Tested with love.


Screenshots
-----------

Usecase 1
  http://git.reviewboard.kde.org/r/108021/s/938/
Usecase 2
  http://git.reviewboard.kde.org/r/108021/s/939/
Usecase 3
  http://git.reviewboard.kde.org/r/108021/s/940/


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121230/ccad33be/attachment.html>


More information about the Marble-devel mailing list