[Marble-devel] Review Request: Added colors to stars
Torsten Rahn
tackat at kde.org
Thu Dec 27 14:49:38 UTC 2012
> On Dec. 27, 2012, 10:37 a.m., Torsten Rahn wrote:
> > Ship It!
>
> Torsten Rahn wrote:
> Timothy: please commit :)
>
> The version supposed to be shipped is the one originally specified one (Adjusted colors stars.dat).
>
> Timothy Lanzi wrote:
> I don't think I can commit. (Don't have commit privileges.) Dennis has been committing all my changes for me.
I just pushed the commit to master. But I think we should give you commit rights :-)
- Torsten
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107906/#review24028
-----------------------------------------------------------
On Dec. 27, 2012, 3:45 a.m., Timothy Lanzi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107906/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2012, 3:45 a.m.)
>
>
> Review request for Marble.
>
>
> Description
> -------
>
> Colors added to stars according to their spectrum description given in the catalog.
>
>
> Diffs
> -----
>
> data/stars/stars.dat 40def72
> src/plugins/render/stars/StarsPlugin.h d979629
> src/plugins/render/stars/StarsPlugin.cpp 4506fd4
> tools/stars/stars.cpp 5cdd997
>
> Diff: http://git.reviewboard.kde.org/r/107906/diff/
>
>
> Testing
> -------
>
> Compiled and ran, checked to see if it worked.
>
>
> Thanks,
>
> Timothy Lanzi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121227/6c493fb9/attachment.html>
More information about the Marble-devel
mailing list