[Marble-devel] Review Request: KML ListStyle Tag Handler

[Mohammed Nafees]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107934/
-----------------------------------------------------------

Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Description
-------

http://www.google-melange.com/gci/task/view/google/gci2012/8040207


Diffs
-----

  src/lib/geodata/data/GeoDataListStyle.h e69de29 
  src/lib/geodata/data/GeoDataListStyle.cpp e69de29 
  src/lib/geodata/data/GeoDataStyle.h e3abbd5 
  src/lib/geodata/data/GeoDataStyle.cpp 01c4a24 
  src/lib/geodata/handlers/kml/KmlBgColorTagHandler.cpp 0e0b5f7 
  src/lib/geodata/handlers/kml/KmlHrefTagHandler.cpp bf8f0a4 
  src/lib/geodata/handlers/kml/KmlItemIconTagHandler.h e69de29 
  src/lib/geodata/handlers/kml/KmlItemIconTagHandler.cpp e69de29 
  src/lib/geodata/handlers/kml/KmlListItemTypeTagHandler.h e69de29 
  src/lib/geodata/handlers/kml/KmlListItemTypeTagHandler.cpp e69de29 
  src/lib/geodata/handlers/kml/KmlListStyleTagHandler.h e69de29 
  src/lib/geodata/handlers/kml/KmlListStyleTagHandler.cpp e69de29 
  src/lib/geodata/handlers/kml/KmlStateTagHandler.h e69de29 
  src/lib/geodata/handlers/kml/KmlStateTagHandler.cpp e69de29 
  src/lib/geodata/parser/GeoDataTypes.h 8ae6a2d 
  src/lib/geodata/parser/GeoDataTypes.cpp 41aa57b 
  tests/CMakeLists.txt 0aa5f9e 
  tests/TestBalloonStyle.cpp dd69f2c 
  tests/TestListStyle.cpp e69de29 

Diff: http://git.reviewboard.kde.org/r/107934/diff/


Testing
-------

yes, testing done but fails for ItemIcon and its subtags (state and href), dunno why its failing to read the tags and hence I want help


Thanks,

Mohammed Nafees

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121227/d1bd35c6/attachment.html>