[Marble-devel] Review Request: RenderPlugin and AbstractFloatItem have been covered with Doxygen

[Illya Kovalevskyy]

> On Dec. 26, 2012, 10:36 p.m., Torsten Rahn wrote:
> > src/lib/AbstractFloatItem.h, line 85
> > <http://git.reviewboard.kde.org/r/107914/diff/2/?file=101608#file101608line85>
> >
> >     I guess that should refer to the GeoPainter :)

Why? In doxygen type will be underlined as a link. So, here we need just a description.


> On Dec. 26, 2012, 10:36 p.m., Torsten Rahn wrote:
> > src/lib/AbstractFloatItem.h, line 84
> > <http://git.reviewboard.kde.org/r/107914/diff/2/?file=101608#file101608line84>
> >
> >     "main render function" ? Is there a "side render function" as well? :-)

Nope. Gonna be fixed.


> On Dec. 26, 2012, 10:36 p.m., Torsten Rahn wrote:
> > src/lib/AbstractFloatItem.h, line 42
> > <http://git.reviewboard.kde.org/r/107914/diff/2/?file=101608#file101608line42>
> >
> >     "is an item displayed on the marble widget". Hm, that also applies to all other render plugins (like the earthquake, wikipedia, postal and flickr items). 
> >

but there are some chars. below - moving for instance


> On Dec. 26, 2012, 10:36 p.m., Torsten Rahn wrote:
> > src/lib/RenderPlugin.h, line 180
> > <http://git.reviewboard.kde.org/r/107914/diff/2/?file=101609#file101609line180>
> >
> >     What kinds of Types are there?

But there are listed in enum, aren't they?


- Illya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107914/#review24010
-----------------------------------------------------------


On Dec. 26, 2012, 9:45 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107914/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2012, 9:45 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> RenderPlugin and AbstractFloatItem have been covered with Doxygen comments according to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8087207
> 
> 
> Diffs
> -----
> 
>   src/lib/AbstractFloatItem.h e7c2c15 
>   src/lib/RenderPlugin.h 1ae5385 
> 
> Diff: http://git.reviewboard.kde.org/r/107914/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121226/825ea509/attachment.html>