[Marble-devel] Review Request: remove network plugin infrastructure -> always use QNetworkAccessManager

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107919/#review23991
-----------------------------------------------------------


Awesome! :-)
Indeed our Network Plugin infrastructure just exists because during the early days of Marble there was just QHttp with all its issues (as the only plain Qt solution) and on the other hand there was KDE's sophisticated KIO mechanism. And QNetworkAccessManager matured only during the last few years up to a point where it's a clear winner now. 
So it's great to see Marble being put on diet again without losing features. Some thoughts:
* Does "File -> Work Offline" still work (up to the point it has worked so far) ? (It would be great if we could make use of more of Qt's Bearer Management features in the future)
* Any thoughts on future refactoring of our HttpDownloadManager (with its caching capabilities and caching policies)?
* Did you test proxy support? I don't see a reason why it shouldn't work anymore - especially since it only worked with QNetworkManager anyways. Still we should test it somewhen before the next release.


- Torsten Rahn


On Dec. 26, 2012, 11:07 a.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107919/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2012, 11:07 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The network plugin infrastructure represents a network abstraction layer.
> However, Marble uses QNetworkAccessManager in a number of places directly, e.g. in the GHNS dialogs and in all the runners.
> Given that QNetworkAccessManager also represents a network abstraction layer, Marble's own network plugin infrastructure shouldn't be neccessary.
> 
> 
> Diffs
> -----
> 
>   src/lib/AbstractDataPlugin.h 37ab9213d8e9a53ccc189b436868fb41a55c7f7a 
>   src/lib/AbstractDataPlugin.cpp 8398e3193dbf8741683547c18007551ca410dabb 
>   src/lib/AbstractDataPluginModel.h 04be73f5edc3197b226f59c6dfacc5c4a6e6374b 
>   src/lib/AbstractDataPluginModel.cpp 92d2cb89e00f5620eff9a2279ccb099266da173c 
>   src/lib/CMakeLists.txt 3d39e739b7c1bfaa46a4e46cd8589e76f707a328 
>   src/lib/HttpDownloadManager.h 0da4b9ef83c9ca2eccf223e76363b0102565ab22 
>   src/lib/HttpDownloadManager.cpp 62c40308b3696758dddf1692de4098c845d23ccf 
>   src/lib/HttpJob.h 5b7565333a9801a5309a2b82d29d52e26cb983df 
>   src/lib/HttpJob.cpp 454c7e6a3ee1732e1cf2c91d3b63b7b52dcd43e9 
>   src/lib/MarbleModel.cpp 5f885e9f3339602df6b59c8a556e16cad487f9e9 
>   src/lib/NetworkPlugin.h 4a4d1f0d2949374bcf45e0d761c7fc1958ef2709 
>   src/lib/NetworkPlugin.cpp 67f257c00647519844e6bf5231c4d8cdf8991ff3 
>   src/lib/NetworkPluginInterface.h 0d198bcf62672a218d6587f1f8a36ffc1ec71151 
>   src/lib/NetworkPluginInterface.cpp 6de86a1301bc07f15ef924bfecbccc0da93a2b67 
>   src/lib/PluginManager.h c9a156de6805509c207914a514121ea2e53e0c90 
>   src/lib/PluginManager.cpp 9c36744b44d1153a35cbd0912b0001cb4b8f9b59 
>   src/plugins/CMakeLists.txt 25c8bdf0df0796df6d7ac39762cc30629b25f71b 
>   src/plugins/declarative/DeclarativeDataPlugin.cpp 0455f9ccf67d2600423b99f1761f792f353ed8ff 
>   src/plugins/declarative/DeclarativeDataPluginModel.h 469975f5547b836d401492089c4bd277a424a575 
>   src/plugins/declarative/DeclarativeDataPluginModel.cpp 48460db9147fce04f966f345e48813620a9816e9 
>   src/plugins/network/CMakeLists.txt 260738f2323c266cc3314e79238a24f1f6d0c628 
>   src/plugins/network/kio/CMakeLists.txt b933ba1cf64b763db9ad037f9213acec6660ac72 
>   src/plugins/network/kio/KIONetworkPlugin.h 33b03c10603ce4b62f288b9568dacac72b78dfe2 
>   src/plugins/network/kio/KIONetworkPlugin.cpp 3adcacacb798a1dedd49fec88016def189fdbf6d 
>   src/plugins/network/qhttp/CMakeLists.txt 7695c93d249c4b305068ace8164063b415227b98 
>   src/plugins/network/qhttp/QHttpNetworkPlugin.h 9cd5186a61a01e1ab5bd8955fafdb041338a6ede 
>   src/plugins/network/qhttp/QHttpNetworkPlugin.cpp fa2dca8ce0fca52751b6af736d2e1a331cd195bc 
>   src/plugins/network/qnam/CMakeLists.txt dffc34413b672874e329b4e1e53250010a1ec35a 
>   src/plugins/network/qnam/QNamDownloadJob.h 674938e851a017d29615305612ffc7082be08cb3 
>   src/plugins/network/qnam/QNamDownloadJob.cpp fb90dac7f3d66b0818ab7aaf174ff0d8dfc0662c 
>   src/plugins/network/qnam/QNamNetworkPlugin.h 2aa11fff0d3efc0580cdd790084449b3c8179861 
>   src/plugins/network/qnam/QNamNetworkPlugin.cpp bf5fbf5917a1e26867cfc9f831cdd56a71f143f4 
>   src/plugins/render/earthquake/EarthquakeModel.h bd74e3a751c64a5bbcde6341d96cbb1835edafc1 
>   src/plugins/render/earthquake/EarthquakeModel.cpp d08c982d0079cf589176b3cffef74400a08779db 
>   src/plugins/render/earthquake/EarthquakePlugin.cpp 014c04f4fd994737ebd208009e932221b3d53395 
>   src/plugins/render/foursquare/FoursquareModel.h 940de81d0bf6d03c1a3dba390284d7074c1db7f5 
>   src/plugins/render/foursquare/FoursquareModel.cpp 9f8374981c8eed6f4e31e0980887f5c4acad490f 
>   src/plugins/render/foursquare/FoursquarePlugin.cpp fc8112fa3f9e82ced8f7aa77c34c704c07c4470e 
>   src/plugins/render/opencachingcom/OpenCachingComModel.h b508006386fe1c99a439c9d1284359174d656ef5 
>   src/plugins/render/opencachingcom/OpenCachingComModel.cpp 9bc2e70ba881a85bd0eb62e31a0eff792dec1fd0 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp 7a017d1d7df21bb27b767b897186936f5722a7db 
>   src/plugins/render/opendesktop/OpenDesktopModel.h 7fe8970873e6ac5357fac242211febd679061b96 
>   src/plugins/render/opendesktop/OpenDesktopModel.cpp fcd5271e983cdb7c24d44e976cffa50904694d9d 
>   src/plugins/render/opendesktop/OpenDesktopPlugin.cpp 883a5a002a523bc354ba5889386ea551bd5eaed1 
>   src/plugins/render/photo/PhotoPlugin.cpp 935fe6e55d350ce434f3ac7c508778f2c98663a0 
>   src/plugins/render/photo/PhotoPluginModel.h a007424982920e60608d05842945c721c74d1b3c 
>   src/plugins/render/photo/PhotoPluginModel.cpp a9d683c6368ab301527956fc8eae7c4c85bfbb2d 
>   src/plugins/render/postalcode/PostalCodeModel.h d285f1fc085ea804053a2b9e06a3cfa949f8f364 
>   src/plugins/render/postalcode/PostalCodeModel.cpp 479ce565ac2e6bd3b2d9cc1ada6a098470fb3b47 
>   src/plugins/render/postalcode/PostalCodePlugin.cpp 2018bc7715178ab065557eaed7b91cde63b6c7ee 
>   src/plugins/render/satellites/SatellitesModel.h f559c9efb16814f34c1c2d818492474fa71faa39 
>   src/plugins/render/satellites/SatellitesModel.cpp a6a6f597f77af0e3f3de65ed3bbff3e40ae6e7f1 
>   src/plugins/render/satellites/SatellitesPlugin.cpp 7344f1bc4677bc0141f24da2ee7240567a642b2c 
>   src/plugins/render/satellites/TrackerPluginModel.h 925b24303e554eb2cba902f39075275aa4a1a6c6 
>   src/plugins/render/satellites/TrackerPluginModel.cpp 5b99631d05e601f2e1db3e013a74a27073f60229 
>   src/plugins/render/weather/WeatherModel.h 7613b5ff640374c1f7052cd7ac3ac2d6f9f2c537 
>   src/plugins/render/weather/WeatherModel.cpp e6580d373ec28e7615021579c6e01b8b2c8c8a4b 
>   src/plugins/render/weather/WeatherPlugin.cpp dd5e3de3ac749bfa51d12b1450c4a75d8901edac 
>   src/plugins/render/wikipedia/WikipediaModel.h 5b78a4e78342641c6ab9613fc9d7043a87208b80 
>   src/plugins/render/wikipedia/WikipediaModel.cpp 58aeb1051dbf386a471f82206a23e2f6b438df97 
>   src/plugins/render/wikipedia/WikipediaPlugin.cpp 43eb1752683643e73fa5f85146f68715e957f962 
>   tests/PluginManagerTest.cpp 58bdfa3fd7c5e26a843ab378aab2610c238d843f 
> 
> Diff: http://git.reviewboard.kde.org/r/107919/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernhard Beschow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121226/0b672800/attachment.html>