[Marble-devel] Review Request: Support of background and text colors for Web Popup

[tackat at t-online.de]

Interesting. So why don't you cache the QPixmap in a QPixmapCache which would have much more of a benefit  :-) ? I mean there is no usage of threads here, so that shouldn' 
t be the issue ...

--
Von meinem Nokia N9 gesendetDennis Nienhüser schrieb am 23.12.12 09:46:

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107826/ 


Ship it! 
Thanks, looks good. I'll push it on your behalf to get it into master quickly. 

- Dennis 

On December 23rd, 2012, 12:39 a.m., Illya Kovalevskyy wrote: 
Review request for Marble, Dennis Nienhüser and Torsten Rahn.
By Illya Kovalevskyy. 
Updated Dec. 23, 2012, 12:39 a.m. 
Description 
Solved according to the GCI task:
 - http://www.google-melange.com/gci/task/view/google/gci2012/8126203 

Testing 
Compiled & Tested & Run on Kubuntu 12.10 with Qt 4.8.3 

Diffs 
src/lib/AbstractInfoDialog.h (4629ef7) 
src/plugins/render/webpopup/PopupItem.h (0180a42) 
src/plugins/render/webpopup/PopupItem.cpp (176ec2b) 
src/plugins/render/webpopup/WebPopupFloatItem.h (648473e) 
src/plugins/render/webpopup/WebPopupFloatItem.cpp (26c8b29) 
View Diff 
Screenshots