[Marble-devel] Review Request: Support of background and text colors for Web Popup

[Illya Kovalevskyy]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107826/
-----------------------------------------------------------

(Updated Dec. 23, 2012, 12:39 a.m.)


Review request for Marble, Dennis Nienhüser and Torsten Rahn.


Changes
-------

Changed according to the newest Marble master. Caching added. Really needs a review!


Description
-------

Solved according to the GCI task:
 - http://www.google-melange.com/gci/task/view/google/gci2012/8126203


Diffs (updated)
-----

  src/lib/AbstractInfoDialog.h 4629ef7 
  src/plugins/render/webpopup/PopupItem.h 0180a42 
  src/plugins/render/webpopup/PopupItem.cpp 176ec2b 
  src/plugins/render/webpopup/WebPopupFloatItem.h 648473e 
  src/plugins/render/webpopup/WebPopupFloatItem.cpp 26c8b29 

Diff: http://git.reviewboard.kde.org/r/107826/diff/


Testing
-------

Compiled & Tested & Run on Kubuntu 12.10 with Qt 4.8.3


Screenshots (updated)
-----------

Previous View
  http://git.reviewboard.kde.org/r/107826/s/922/
Current View
  http://git.reviewboard.kde.org/r/107826/s/924/


Thanks,

Illya Kovalevskyy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121223/b95ef773/attachment.html>