[Marble-devel] Review Request: Add support for remote icon/image in kml

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107846/#review23848
-----------------------------------------------------------


Looks great in general, but shouldn't this use Marble's HttpDownloadManager class instead ? That would allow for different backends, caching, central download management, etc. .. 


src/lib/geodata/data/RemoteIconLoader.cpp
<http://git.reviewboard.kde.org/r/107846/#comment18210>

    Doesn't this create the very same connection on the same object everytime something is loaded? I guess this should be called in the ctor instead ...


- Torsten Rahn


On Dec. 22, 2012, 12:05 p.m., Shou Ya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107846/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2012, 12:05 p.m.)
> 
> 
> Review request for Marble and Dennis Nienhüser.
> 
> 
> Description
> -------
> 
> In this patch I added a class RemoteIconLoader to implement this function.
> 
> This is a Google Code-in task(https://www.google-melange.com/gci/task/view/google/gci2012/8021203).
> 
> 
> This addresses bug 310464.
>     http://bugs.kde.org/show_bug.cgi?id=310464
> 
> 
> Diffs
> -----
> 
>   src/lib/CMakeLists.txt aa93315 
>   src/lib/geodata/data/GeoDataIconStyle.h 18ae3a8 
>   src/lib/geodata/data/GeoDataIconStyle.cpp b221821 
>   src/lib/geodata/data/RemoteIconLoader.h PRE-CREATION 
>   src/lib/geodata/data/RemoteIconLoader.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shou Ya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121222/25147996/attachment.html>