[Marble-devel] Review Request: Invoke WebPopupItem instead of PlacemarkInfoDialog whenever the Placemark's role is empty
Torsten Rahn
tackat at kde.org
Sat Dec 22 12:27:24 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107844/#review23840
-----------------------------------------------------------
Ship it!
Ship It!
- Torsten Rahn
On Dec. 22, 2012, 11:21 a.m., Illya Kovalevskyy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107844/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2012, 11:21 a.m.)
>
>
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
>
>
> Description
> -------
>
> Invoke WebPopupItem instead of PlacemarkInfoDialog whenever the Placemark's role is empty.
>
> Add.: https://google-melange.appspot.com/gci/task/view/google/gci2012/8067207
>
>
> Diffs
> -----
>
> src/lib/MarbleWidgetPopupMenu.cpp 4da64b0
> src/plugins/render/webpopup/PopupItem.cpp f76adcd
> src/plugins/render/webpopup/WebPopupFloatItem.h 646b236
>
> Diff: http://git.reviewboard.kde.org/r/107844/diff/
>
>
> Testing
> -------
>
> Built & Run on Kubuntu Linux 12.10 with Qt 4.8.3
>
>
> Screenshots
> -----------
>
> Current View
> http://git.reviewboard.kde.org/r/107844/s/923/
>
>
> Thanks,
>
> Illya Kovalevskyy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121222/1c0fc6d4/attachment.html>
More information about the Marble-devel
mailing list