[Marble-devel] Review Request: Fix planet order in List

Dennis Nienhüser earthwings at gentoo.org
Fri Dec 14 20:24:36 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107727/#review23481
-----------------------------------------------------------

Ship it!


Works fine. Please adjust for code style (see below) and commit to kitchen.


src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/107727/#comment18058>

    Please use curly brackets -- { and } -- also for one-liners. Same for the next lines.



src/lib/MapViewWidget.cpp
<http://git.reviewboard.kde.org/r/107727/#comment18057>

    m_priority


- Dennis Nienhüser


On Dec. 14, 2012, 8:10 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107727/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 8:10 p.m.)
> 
> 
> Review request for Marble, Dennis Nienhüser and Torsten Rahn.
> 
> 
> Description
> -------
> 
> According to the GCI task:
>  - https://google-melange.appspot.com/gci/task/view/google/gci2012/8096203
> 
> 
> Diffs
> -----
> 
>   src/lib/MapViewWidget.cpp 994707b 
> 
> Diff: http://git.reviewboard.kde.org/r/107727/diff/
> 
> 
> Testing
> -------
> 
> Built & Run & Tested on Kubuntu 12.10 with Qt 4.8.3
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121214/ad14679b/attachment.html>


More information about the Marble-devel mailing list