[Marble-devel] Review Request: Render License/Copyright into the copied/printed map

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107620/#review23236
-----------------------------------------------------------



src/lib/graphicsview/ScreenGraphicsItem.h
<http://git.reviewboard.kde.org/r/107620/#comment17818>

    Way cool, so we have a new generic feature :-) Awesome :-) !!!!



src/plugins/render/license/License.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17803>

    Is there any reason not to call the just "update()" ?



src/plugins/render/license/License.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17805>

    It's always a good idea to use QFontMetricsF instead of QFontMetrics. QFontMetrics will frequently cut off parts of the text - even if it doesn't happen on your platform it will maybe happen on Mac or Windows ... :-(
    So better use QFontMetricsF


- Torsten Rahn


On Dec. 9, 2012, 10:35 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107620/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 10:35 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Task was solved according to the statements:
>  1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
>  2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
>  3. http://www.google-melange.com/gci/task/view/google/gci2012/8018213
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml 5eb6e2b 
>   data/maps/earth/citylights/citylights.dgml 8db9b13 
>   data/maps/earth/openstreetmap/openstreetmap.dgml b26e5e1 
>   data/maps/earth/plain/plain.dgml e27eda2 
>   data/maps/earth/temp-july/temp-july.dgml e8372df 
>   src/ControlView.h 756ecb7 
>   src/ControlView.cpp 55d56f5 
>   src/QtMainWindow.cpp ae34e7c 
>   src/lib/AbstractFloatItem.cpp 15ceebb 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h 8a590e8 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.cpp c8b6f99 
>   src/lib/geodata/handlers/dgml/DgmlLicenseTagHandler.cpp 9b8a7bc 
>   src/lib/geodata/scene/GeoSceneLicense.h 7176c12 
>   src/lib/geodata/scene/GeoSceneLicense.cpp c5a5e6d 
>   src/lib/graphicsview/ScreenGraphicsItem.h ef19746 
>   src/plugins/render/CMakeLists.txt 4e550c0 
>   src/plugins/render/license/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/license/License.h PRE-CREATION 
>   src/plugins/render/license/License.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107620/diff/
> 
> 
> Testing
> -------
> 
> Built, run and tested on Ubuntu Linux 12.10 (Qt 4.8.3; Intel)
> 
> 
> Screenshots
> -----------
> 
> Full Request Stuff
>   http://git.reviewboard.kde.org/r/107620/s/886/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121209/bb34fad5/attachment.html>