[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Torsten Rahn]

> On Dec. 7, 2012, 5:38 a.m., Torsten Rahn wrote:
> > data/stars/constellations.dat, line 63
> > <http://git.reviewboard.kde.org/r/107571/diff/6/?file=97475#file97475line63>
> >
> >     Please also add
> >     
> >     Bootes
> >     5235 5340 5506 5681 5602 5435 5429 5340 5477
> >     Cepheus
> >     8974 8238 8162 8571 8694 8974
> >     Perseus
> >     1203 1228 1220 1122 1087 1087 1017 915 834 -1 1017 941 936 921
> >     Draco
> >     4434 4787 5291 5744 5986 6132 6396 6927 7582 7310 6688 6554 6536 6705 6688
> >     Auriga
> >     1577 2095 2088 1708 1605 1641 1612 1577
> >     Herkules
> >     6095 6148 6212 6220 6168 6092 -1 6212 6324 6410 (6526) 6623 -1 6324 6418 6485 6695 -1 6418 6220
> >     Corona Borealis
> >     5778 5747 5793 5849 5889 5947
> >     Lepus
> >     1865 1702 1654 1829 1865
> >     Corvus
> >     4757 4662 4630 4786 4757
> >     Crux
> >     4763 4730 -1 4656 4853
> >     
> >     ... which got kindly provided by Alex!
> 
> Timothy Lanzi wrote:
>     Will do. Are these the only ones, or are there more somewhere? I saw that he was going to attach something to this review request (which has gotten quite big), but I have not been able to see it.

No that's all :)
I guess at one point I'll just create a task that has all the remaining bigger constellations.


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review23111
-----------------------------------------------------------


On Dec. 7, 2012, 4:20 a.m., Timothy Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 4:20 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Constellation extension to stars plugin. 
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 
> 
> 
> Diffs
> -----
> 
>   data/stars/constellations.dat PRE-CREATION 
>   data/stars/deepsky.png PRE-CREATION 
>   data/stars/dso.dat PRE-CREATION 
>   data/stars/stars.dat 14a0723 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
>   tools/stars/stars.cpp 1542092 
> 
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
> 
> 
> Testing
> -------
> 
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
> 
> 
> Thanks,
> 
> Timothy Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121209/3e515bc3/attachment-0001.html>