[Marble-devel] Review Request: Render License/Copyright into the copied/printed map

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107620/#review23158
-----------------------------------------------------------


Looks great to me.


src/ControlView.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17722>

    I suggest you get marbleWidget->defaultFont() instead and make that font then bold.



src/ControlView.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17721>

    It would be good to use a QPointer here, see:
    
    http://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0



src/ControlView.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17719>

    What about naming this in an even more understandable way?
    
    "Proper Credits"?



src/ControlView.cpp
<http://git.reviewboard.kde.org/r/107620/#comment17720>

    I think we should change this as part of a future task: 
    Currently we have two buttons with a long text. this will create problems with translations. Imagine the button to be twice the size of the english version ...
    But for now we can imho keep the QMessageBox solution.
    Maybe in a new dialog we could also do some better information about the license / attribution duties ...


- Torsten Rahn


On Dec. 8, 2012, 3:58 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107620/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 3:58 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Task was solved according to the statements:
>  1. https://google-melange.appspot.com/gci/task/view/google/gci2012/8015212
>  2. http://www.google-melange.com/gci/task/view/google/gci2012/8006226
>  3. http://www.google-melange.com/gci/task/view/google/gci2012/8018213
> 
> 
> Diffs
> -----
> 
>   data/maps/earth/bluemarble/bluemarble.dgml 5eb6e2b 
>   data/maps/earth/citylights/citylights.dgml 8db9b13 
>   data/maps/earth/openstreetmap/openstreetmap.dgml b26e5e1 
>   data/maps/earth/plain/plain.dgml e27eda2 
>   data/maps/earth/temp-july/temp-july.dgml e8372df 
>   src/ControlView.h 756ecb7 
>   src/ControlView.cpp 55d56f5 
>   src/QtMainWindow.cpp ae34e7c 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.h 8a590e8 
>   src/lib/geodata/handlers/dgml/DgmlAttributeDictionary.cpp c8b6f99 
>   src/lib/geodata/handlers/dgml/DgmlLicenseTagHandler.cpp 9b8a7bc 
>   src/lib/geodata/scene/GeoSceneLicense.h 7176c12 
>   src/lib/geodata/scene/GeoSceneLicense.cpp c5a5e6d 
> 
> Diff: http://git.reviewboard.kde.org/r/107620/diff/
> 
> 
> Testing
> -------
> 
> Built, run and tested on Ubuntu Linux 12.10 (Qt 4.8.3; Intel)
> 
> 
> Screenshots
> -----------
> 
> Marble Copyright Issues
>   http://git.reviewboard.kde.org/r/107620/s/885/
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121208/d3097eb2/attachment.html>