[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Torsten Rahn]

> On Dec. 7, 2012, 10:59 a.m., Torsten Rahn wrote:
> > src/plugins/render/stars/StarsPlugin.cpp, line 416
> > <http://git.reviewboard.kde.org/r/107571/diff/6/?file=97480#file97480line416>
> >
> >     I just discovered that there is a bug here:
> >     This call needs to be
> >     
> >     painter->drawEllipse(QPointF(x,y), size / 2, size / 2 );
> >     
> >     Otherwise the ellipse is not painted with x,y being the center but the top left! And that means that the coordinate lines don't line up.
> >     Have a close look at Sirius to see it!
> 
> Torsten Rahn wrote:
>     Actually it needs to be 
>     
>                 painter->drawEllipse(QRectF(x - size/2.0, y - size/2.0, size, size));
>     
>     since the other method is overshadowed.

Wow, trying that out (together with the suggested initial rendering of the constellations and stars only afterwards) this looks much better and there are many more stars visible even (since the small stars' radius doesn't get casted to 0).
So Timothy, it would be great if you could import this fix into your reviewrequest! :)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review23118
-----------------------------------------------------------


On Dec. 7, 2012, 4:20 a.m., Timothy Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 4:20 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Constellation extension to stars plugin. 
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 
> 
> 
> Diffs
> -----
> 
>   data/stars/constellations.dat PRE-CREATION 
>   data/stars/deepsky.png PRE-CREATION 
>   data/stars/dso.dat PRE-CREATION 
>   data/stars/stars.dat 14a0723 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
>   tools/stars/stars.cpp 1542092 
> 
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
> 
> 
> Testing
> -------
> 
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
> 
> 
> Thanks,
> 
> Timothy Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121207/f78c0b52/attachment-0001.html>