[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Timothy Lanzi]

> On Dec. 5, 2012, 11:43 p.m., Torsten Rahn wrote:
> > data/stars/constellations.dat, line 26
> > <http://git.reviewboard.kde.org/r/107571/diff/2/?file=97188#file97188line26>
> >
> >     It would be great if you followed the constellation pattern that I provided as a pdf. In this case you've included eps Lyr which is not the case in the PDF :-)
> >     
> >     The constellation lines in the PDF are  intentionally kept very simple (to avoid overwhelming and to provide the lowest common denominator of the different constellation line variations that are used across cultures).
> >
> 
> Torsten Rahn wrote:
>     Just wanted to tell this to avoid that you go to lengths to paint all the different possible lines in Sagitarius ;-))) 
>     But I think in general we should follow the KISS principle for the constellation lines - makes it easier to memorize them. We could have "more/extended lines" displayed in darker gray as an option in the future.
>     But your stuff currently meets this criterion very well, so forget about what I'm saying ;-)

I have been following the lines in the PDF, but Lyra was a tiny constellation in there, so it was kind of difficult to tell where there were lines in certain parts of it.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review23050
-----------------------------------------------------------


On Dec. 5, 2012, 11:39 p.m., Timothy Lanzi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 11:39 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Constellation extension to stars plugin. 
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 
> 
> 
> Diffs
> -----
> 
>   data/stars/constellations.dat PRE-CREATION 
>   data/stars/stars.dat 14a0723 
>   src/plugins/render/stars/StarsPlugin.h 6aeebf5 
>   src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
>   tools/stars/stars.cpp 1542092 
> 
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
> 
> 
> Testing
> -------
> 
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
> 
> 
> Thanks,
> 
> Timothy Lanzi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121206/f99cea04/attachment.html>