[Marble-devel] Review Request: Constellation Extension to Stars Plugin
Timothy Lanzi
trlanzi at gmail.com
Wed Dec 5 23:41:10 UTC 2012
> On Dec. 4, 2012, 10:37 a.m., Dennis Nienhüser wrote:
> > src/plugins/render/stars/StarsPlugin.h, line 169
> > <http://git.reviewboard.kde.org/r/107571/diff/1/?file=97135#file97135line169>
> >
> > m_idMap
> >
> > This looks quite c-ish. Can't we use a QVector<int> or a QMap<int,int> instead for example?
> >
>
> Timothy Lanzi wrote:
> This is above me right now but I'll see what I can do.
Replaced with QHash in diff rev 3.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/#review22961
-----------------------------------------------------------
On Dec. 5, 2012, 11:39 p.m., Timothy Lanzi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107571/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2012, 11:39 p.m.)
>
>
> Review request for Marble.
>
>
> Description
> -------
>
> Constellation extension to stars plugin.
> Extended stars plugin to read constellation.dat file and draw constellation lines/labels.
>
>
> Diffs
> -----
>
> data/stars/constellations.dat PRE-CREATION
> data/stars/stars.dat 14a0723
> src/plugins/render/stars/StarsPlugin.h 6aeebf5
> src/plugins/render/stars/StarsPlugin.cpp 1bced5e
> tools/stars/stars.cpp 1542092
>
> Diff: http://git.reviewboard.kde.org/r/107571/diff/
>
>
> Testing
> -------
>
> Basic operational testing. Plugin compiles without warning and runs with the data files supplied.
>
>
> Thanks,
>
> Timothy Lanzi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/b09721ac/attachment.html>
More information about the Marble-devel
mailing list