[Marble-devel] Review Request: Caching The Atmosphere

[Torsten Rahn]

> On Dec. 5, 2012, 5:08 a.m., Torsten Rahn wrote:
> > src/plugins/render/atmosphere/AtmospherePlugin.cpp, line 158
> > <http://git.reviewboard.kde.org/r/107581/diff/2/?file=97196#file97196line158>
> >
> >     this should probably be uncommented now and read
> >     int size = (int) ( 2.1 * (qreal) ( viewParams->radius()));
> >     if (size < 1) return;
> >     m_renderPixmap = QPixmap(size, size);
> >
> 
> Illya Kovalevskyy wrote:
>     By the way, this code won't work.
>     
>     QPixmap(size, size) return is const pointer. We can't set it to QPixmap.
>     
>     How to deal with it?

look closer. There is no "new" there. So no pointer there ... :-)


- Torsten


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107581/#review23010
-----------------------------------------------------------


On Dec. 5, 2012, 4:55 a.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107581/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2012, 4:55 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> I tried to increase performance with caching the atmosphere into QPixmap.
> Task on GCI: http://www.google-melange.com/gci/task/view/google/gci2012/7989206
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/atmosphere/AtmospherePlugin.h d662509 
>   src/plugins/render/atmosphere/AtmospherePlugin.cpp e6b531f 
> 
> Diff: http://git.reviewboard.kde.org/r/107581/diff/
> 
> 
> Testing
> -------
> 
> Successfully built on Ubuntu Linux 12.10 (Intel)
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/ea0832d2/attachment.html>