[Marble-devel] Review Request: Constellation Extension to Stars Plugin

[Timothy Lanzi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107571/
-----------------------------------------------------------

(Updated Dec. 5, 2012, 3:34 a.m.)


Review request for Marble.


Changes
-------

Responded to 90% of Dennis's comments. Also, extended the constellations to permit blank and dashed lines. Added Cygnus, Lyra, and Aquila.


Description
-------

Constellation extension to stars plugin. 
Extended stars plugin to read constellation.dat file and draw constellation lines/labels. 


Diffs (updated)
-----

  data/stars/constellations.dat PRE-CREATION 
  data/stars/stars.dat 14a0723 
  src/plugins/render/stars/StarsPlugin.h 6aeebf5 
  src/plugins/render/stars/StarsPlugin.cpp 1bced5e 
  tools/stars/stars.cpp 1542092 

Diff: http://git.reviewboard.kde.org/r/107571/diff/


Testing
-------

Basic operational testing. Plugin compiles without warning and runs with the data files supplied.


Thanks,

Timothy Lanzi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/7af86a7a/attachment-0001.html>