[Marble-devel] Review Request: Caching The Atmosphere

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107581/#review23002
-----------------------------------------------------------


Looks great. Can you correct the issues? :-)


src/plugins/render/atmosphere/AtmospherePlugin.h
<http://git.reviewboard.kde.org/r/107581/#comment17560>

    QPixmaps should normally be created on the stack. 



src/plugins/render/atmosphere/AtmospherePlugin.cpp
<http://git.reviewboard.kde.org/r/107581/#comment17561>

    Imho it would be nicer if you created the QPainter on the stack and called begin() and end():
    
    QPainter painter;
    painter.begin(&m_renderPixmap);
    ....
    painter.end();


- Torsten Rahn


On Dec. 4, 2012, 11:07 p.m., Illya Kovalevskyy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107581/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 11:07 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> I tried to increase performance with caching the atmosphere into QPixmap.
> Task on GCI: http://www.google-melange.com/gci/task/view/google/gci2012/7989206
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/atmosphere/AtmospherePlugin.h d662509 
>   src/plugins/render/atmosphere/AtmospherePlugin.cpp e6b531f 
> 
> Diff: http://git.reviewboard.kde.org/r/107581/diff/
> 
> 
> Testing
> -------
> 
> Successfully built on Ubuntu Linux 12.10 (Intel)
> 
> 
> Thanks,
> 
> Illya Kovalevskyy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121205/333af643/attachment.html>