[Marble-devel] Review Request: Opencaching.com plugin: Add background to icons to support dark color schemes

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107564/#review22933
-----------------------------------------------------------

Ship it!


Ship It!

- Torsten Rahn


On Dec. 3, 2012, 10:58 a.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107564/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 10:58 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> The icons used in the opencaching.com plugin are dark brown with transperant background, potentially making them [almost] invisible for users with dark color schemes. By having a light background, this issue is prevented. Color is taken from opencaching.com palette.
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/opencachingcom/boat-required.png 8c99293d4483a685dc1f84339c09760181d376c1 
>   src/plugins/render/opencachingcom/chirp.png 57f8954d7d9849bd1490585e2ce68579983b4a68 
>   src/plugins/render/opencachingcom/diving.png db447e0a9ec00cd88b89a781b20b118bf966c5cc 
>   src/plugins/render/opencachingcom/exclusive.png 7f846ce01be302e922e5703a032f8de64ddb88a3 
>   src/plugins/render/opencachingcom/historic-site.png 4b2b1f2921d25ec2139df4dcf7185bb2cf4ff9c4 
>   src/plugins/render/opencachingcom/letterbox.png 6af29402f937b7ce2dc99ba4d1329e0bbd02ca40 
>   src/plugins/render/opencachingcom/multi-cache.png fc9673b9f7d21e2f614a8e3e082ccb7a580cb4d4 
>   src/plugins/render/opencachingcom/night.png a7c9d4af9d37a08f7189c20b62f2752a325368f8 
>   src/plugins/render/opencachingcom/puzzle.png 90fd79b3a29a9a8b4311ef77736a52571e24da53 
>   src/plugins/render/opencachingcom/traditional.png 311bc50e45b9b9f69a96e7be327b04beb0f85db1 
>   src/plugins/render/opencachingcom/tree-climbing.png a134ed3035f88d3e9f16e0dac2c3ea62b82ed3ac 
>   src/plugins/render/opencachingcom/unknown.png 24c79c1ba923d9dd1fe4eb3c9fbf128b2d3ad6af 
>   src/plugins/render/opencachingcom/uv-light.png 0e46190c9a13ccd5b7ef5994569d2111f774e1a3 
>   src/plugins/render/opencachingcom/verifiable.png d17a0e9d06d76d2e0334361bb2f08f8e82b9c046 
> 
> Diff: http://git.reviewboard.kde.org/r/107564/diff/
> 
> 
> Testing
> -------
> 
> builds, compiles, functions
> 
> 
> Screenshots
> -----------
> 
> before
>   http://git.reviewboard.kde.org/r/107564/s/866/
> after
>   http://git.reviewboard.kde.org/r/107564/s/867/
> tooltip, after
>   http://git.reviewboard.kde.org/r/107564/s/868/
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121203/a829cff3/attachment.html>