[Marble-devel] Review Request: Add opencaching.com render plugin

[Torsten Rahn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107510/#review22857
-----------------------------------------------------------

Ship it!


It's flattering that you use unfair methods to lure me into giving a "Ship It": The screenshot you provide shows "Munkbrarup" which is very close to my hometown Flensburg. Lovely :-)


src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17433>

    hasposition -> hasPosition



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17439>

    I don't know ;-) But maybe put a TODO in front



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17438>

    hasposition -> hasPosition



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17440>

    why is this commented out? Would be  nice if there was at least a comment about it.



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17434>

    Should we use mostly the "normal" oxygen colors for all the colors used? In this case I'm not sure. http://www.oxygen-icons.org/wp-content/themes/oxy/images/figure4.png Are there colors close to the ones used on the remote services website? 
    
    



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17436>

    See above



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17435>

    See above



src/plugins/render/opencachingcom/OpenCachingComItem.cpp
<http://git.reviewboard.kde.org/r/107510/#comment17437>

    I guess we should have code like this in a more generic place in the future, so that it can be used elsewhere.


- Torsten Rahn


On Nov. 30, 2012, 11:25 p.m., Anders Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107510/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 11:25 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Adds a render plugins showing geocaches from opencaching.com on the map.
> 
> Capabilities:
> * shows geocaches on the map, using icons derived from opencaching.com graphics
> * shows a tooltip with the most important data when icons are hovered
> * provides a dialog with details, description, hint and recent logs for each geocache
> * the dialog shows the distance to the cache if available, otherwise the distance to the users home location as known by marble (calculated at the time the dialog is shown)
> 
> Good translation support, ui and known translatable datas from the remote service are marked for translation.
> The plugin is trying to use graphics and colors from the remote service in an unobtrusive way, so that the data is easily recognizable but does not interfer with the application or desktop style.
> 
> Possible future improvements:
> * show geocache tags in graphical form (easy)
> * show opencaching "verifyable" attributes for each cache (easy)
> * allow registering/logging a visit to a cache (requires oauth based login)
> * show users found caches by marking the icons with an emblem or special color (requires oauth based login)
> * update distance data in dialog when it changes (easy)
> * show a "go to" widget with live updated distance/bearing/course
> 
> You can find icons here: http://owncloud.alweb.dk/public.php?service=files&file=%2Fanders%2Ffiles%2Foccicons.tar.bz2 - unpack in marble root directory
> 
> 
> Diffs
> -----
> 
>   src/plugins/render/opencachingcom/CMakeLists.txt PRE-CREATION 
>   src/plugins/render/opencachingcom/CacheDetailsDialog.ui PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComItem.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComItem.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComModel.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComModel.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.h PRE-CREATION 
>   src/plugins/render/opencachingcom/OpenCachingComPlugin.cpp PRE-CREATION 
>   src/plugins/render/opencachingcom/multi-cache-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/multi-cache.png PRE-CREATION 
>   src/plugins/render/opencachingcom/opencachingcom.qrc PRE-CREATION 
>   src/plugins/render/opencachingcom/puzzle-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/puzzle.png PRE-CREATION 
>   src/plugins/render/opencachingcom/traditional-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/traditional.png PRE-CREATION 
>   src/plugins/render/opencachingcom/unknown-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/unknown.png PRE-CREATION 
>   src/plugins/render/opencachingcom/virtual-m.png PRE-CREATION 
>   src/plugins/render/opencachingcom/virtual.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107510/diff/
> 
> 
> Testing
> -------
> 
> Builds, compiles and functions
> 
> 
> Screenshots
> -----------
> 
> opencaching.com data and tooltip
>   http://git.reviewboard.kde.org/r/107510/s/858/
> Cache details dialog
>   http://git.reviewboard.kde.org/r/107510/s/859/
> 
> 
> Thanks,
> 
> Anders Lund
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20121201/cd62b166/attachment-0001.html>