[Marble-devel] Review Request: Kothic Json parser for vector data tiles

[Ander Pijoan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106008/
-----------------------------------------------------------

(Updated Aug. 14, 2012, 12:40 p.m.)


Review request for Marble.


Changes
-------

Changed GeoDataDocument and added Fixme for better ring appending in parsing.


Description
-------

During GSoC 2012 for vector tile rendering, Kothic's servers json tiles (hosted on http://osmosnimki.ru/vtile/ - please don't use it heavily-loaded projects for now) have been used while OpenStreetMap finishes building its own data tile server. These Kothic tiles have a very similar format (https://github.com/kothic/kothic-js/wiki/Tiles-format) to the ones that OSM will have.

A problem was found with QScriptValue for multidimensional arrays. When having for example [[20,10],[20,30].[30,30]] if we extract the property it will flatten to 20,10,20,30,30,30. This parser doesn't create separate inner geometries because of this. It will connect the inner geometry with its outer.

It will set the geometries name and style according to what OsmVisualCategory generates for the parsed tags.

This parser creates a GeoDataDocument with all the extracted data.


Diffs (updated)
-----

  src/plugins/runner/CMakeLists.txt 4ab295a 
  src/plugins/runner/json/CMakeLists.txt PRE-CREATION 
  src/plugins/runner/json/JsonParser.h PRE-CREATION 
  src/plugins/runner/json/JsonParser.cpp PRE-CREATION 
  src/plugins/runner/json/JsonPlugin.h PRE-CREATION 
  src/plugins/runner/json/JsonPlugin.cpp PRE-CREATION 
  src/plugins/runner/json/JsonRunner.h PRE-CREATION 
  src/plugins/runner/json/JsonRunner.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106008/diff/


Testing
-------


Screenshots
-----------

Kothic Json Parser
  http://git.reviewboard.kde.org/r/106008/s/676/


Thanks,

Ander Pijoan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120814/dcbc3e5e/attachment.html>