[Marble-devel] Review Request: Extension for the .osm file parser.

[Ander Pijoan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106007/
-----------------------------------------------------------

(Updated Aug. 14, 2012, 11:37 a.m.)


Review request for Marble.


Changes
-------

Changes made.


Description
-------

Extension for the .osm file parser. Relations can be built with different ways (for example for describing a building with a hole in it) tagged as members.

So with this diff, <member> tag is parsed and ways are stored for then a relation to have them available if necessary.

Moreover a relation can also contain another relation, so a relation factory has also been created to store them.


Diffs (updated)
-----

  src/plugins/runner/osm/CMakeLists.txt 6e92624 
  src/plugins/runner/osm/OsmParser.cpp 5285566 
  src/plugins/runner/osm/handlers/OsmElementDictionary.h 2d40f6b 
  src/plugins/runner/osm/handlers/OsmElementDictionary.cpp c99d4a9 
  src/plugins/runner/osm/handlers/OsmGlobals.cpp 0b5ea25 
  src/plugins/runner/osm/handlers/OsmMemberTagHandler.h PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmNodeFactory.h b9c6580 
  src/plugins/runner/osm/handlers/OsmNodeFactory.cpp c51e373 
  src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp f433a5d 
  src/plugins/runner/osm/handlers/OsmOsmTagHandler.cpp 997f628 
  src/plugins/runner/osm/handlers/OsmRelationFactory.h PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmRelationFactory.cpp PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmRelationTagHandler.h PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 057eb63 
  src/plugins/runner/osm/handlers/OsmWayFactory.h PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmWayFactory.cpp PRE-CREATION 
  src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp fdcd2a8 

Diff: http://git.reviewboard.kde.org/r/106007/diff/


Testing
-------

Testing done with some .osm files with different ways of representing buildings and using relations. Works OK.


Screenshots
-----------

Osm parser test
  http://git.reviewboard.kde.org/r/106007/s/675/


Thanks,

Ander Pijoan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120814/aaeef1df/attachment.html>