[Marble-devel] Review Request: Extension for the .som file parser.

[Thibaut Gridel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106007/#review17360
-----------------------------------------------------------



src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp
<http://git.reviewboard.kde.org/r/106007/#comment13542>

    Any reason why not using l->at(x) directly?
    Thinking of GeoDataCoordinates copy ctor.



src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp
<http://git.reviewboard.kde.org/r/106007/#comment13543>

    why not use == instead of operator== ?



src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp
<http://git.reviewboard.kde.org/r/106007/#comment13544>

    = instead of operator= ?


- Thibaut Gridel


On Aug. 14, 2012, 8:43 a.m., Ander Pijoan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106007/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 8:43 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> Extension for the .osm file parser. Relations can be built with different ways (for example for describing a building with a hole in it) tagged as members.
> 
> So with this diff, <member> tag is parsed and ways are stored for then a relation to have them available if necessary.
> 
> Moreover a relation can also contain another relation, so a relation factory has also been created to store them.
> 
> 
> Diffs
> -----
> 
>   src/plugins/runner/osm/CMakeLists.txt 6e92624 
>   src/plugins/runner/osm/OsmParser.cpp 5285566 
>   src/plugins/runner/osm/handlers/OsmElementDictionary.h 2d40f6b 
>   src/plugins/runner/osm/handlers/OsmElementDictionary.cpp c99d4a9 
>   src/plugins/runner/osm/handlers/OsmGlobals.cpp 0b5ea25 
>   src/plugins/runner/osm/handlers/OsmMemberTagHandler.h PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmNodeFactory.h b9c6580 
>   src/plugins/runner/osm/handlers/OsmNodeFactory.cpp c51e373 
>   src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp f433a5d 
>   src/plugins/runner/osm/handlers/OsmOsmTagHandler.cpp 997f628 
>   src/plugins/runner/osm/handlers/OsmRelationFactory.h PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmRelationFactory.cpp PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmRelationTagHandler.h PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp 7a8f432 
>   src/plugins/runner/osm/handlers/OsmWayFactory.h PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmWayFactory.cpp PRE-CREATION 
>   src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp fdcd2a8 
> 
> Diff: http://git.reviewboard.kde.org/r/106007/diff/
> 
> 
> Testing
> -------
> 
> Testing done with some .osm files with different ways of representing buildings and using relations. Works OK.
> 
> 
> Screenshots
> -----------
> 
> Osm parser test
>   http://git.reviewboard.kde.org/r/106007/s/675/
> 
> 
> Thanks,
> 
> Ander Pijoan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120814/e1940cf2/attachment.html>