[Marble-devel] Review Request: First version of flightgear position provider plugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104736/#review13077
-----------------------------------------------------------


Looks great, thanks for the patch! :-)

I tested this on Linux (Kubuntu 12.04), where it works flawlessly. The only problem I see is that the dependency (nmea library from http://nmea.sourceforge.net/) is not packaged for e.g. Debian and *buntu, so it's unlikely that distributions will ship the plugin... which would be a pity. Maybe we can find a Debian guy willing to package and maintain it or find a replacement for it in the future.

If anyone else wants to give it a try, you need to start flightgear like this: fgfs --nmea=socket,out,5,localhost,5500,udp
A Debian package for the nmea library is at http://nienhueser.de/marble/libnmea/
The CMakeLists.txt is a replacement for the Makefile of the library (which didn't behave sane for building a package).



CMakeLists.txt
<http://git.reviewboard.kde.org/r/104736/#comment10243>

    Doesn't work here for some reason (cmake doesn't find the Findnmealib.cmake file). I'd suggest simply placing the .cmake file next to the other ones in the marble root folder.
    



cmake/modules/Findnmealib.cmake
<http://git.reviewboard.kde.org/r/104736/#comment10240>

    For consistency I'd strip the lib postfix everywhere, i.e. use Findnmea.cmake, NMEA_FOUND, ...
    



cmake/modules/Findnmealib.cmake
<http://git.reviewboard.kde.org/r/104736/#comment10239>

    Unless it's taken directly from Kitware, please add your name here for copyright (you can credit Kitware, but not claim copyright for them unless you work for them).
    



src/plugins/positionprovider/flightgear/CMakeLists.txt
<http://git.reviewboard.kde.org/r/104736/#comment10181>

    I need a
    
    INCLUDE_DIRECTORIES(
     ${CMAKE_CURRENT_SOURCE_DIR}/src/plugins/positionprovider/flightgear
     ${CMAKE_BINARY_DIR}/src/plugins/positionprovider/flightgear
     ${QT_INCLUDE_DIR}
    )
    
    otherwise the .moc file is not found
    



src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/104736/#comment10241>

    Wrong copyright header, please remove ewoerner and add yourself.



src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/104736/#comment10242>

    I read this as #ifndef NMEA_TUD_FEED being a version check for nmealib <= 0.5.3.
    
    Wouldn't the following work as well?
    
    qreal elevation = m_info.elv;
    #ifndef NMEA_TUD_FEED
    elevation *= 0.3048;
    #endif
    
    The advantage is that you don't create a "foreign" #define
    


- Dennis Nienhüser


On April 27, 2012, 6:27 a.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104736/
> -----------------------------------------------------------
> 
> (Updated April 27, 2012, 6:27 a.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> When selecting the plugin in the current location panel it starts listen on an udp socket (localhost:5500), which is the default port flightgear uses for exporting map display information. The data send to this port is build as gps data in nmea format.
> 
> The plugin depends on the mnea library http://nmea.sourceforge.net/. The presence of this library is checked on configure time. Building of this plugins only happens when this library is available. 
> 
> On windows the nmea library has been added to the KDE on windows build enviroment. 
> 
> 
> This addresses bug 298785.
>     http://bugs.kde.org/show_bug.cgi?id=298785
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d6466aa 
>   cmake/modules/Findnmealib.cmake PRE-CREATION 
>   src/plugins/positionprovider/CMakeLists.txt bebe774 
>   src/plugins/positionprovider/flightgear/CMakeLists.txt PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.h PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104736/diff/
> 
> 
> Testing
> -------
> 
> succesfull build and tested on windows 7 with msvc 2010 in debug and release mode
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120430/bdf83760/attachment.html>