[Marble-devel] Review Request: First version of flightgear position provider plugin

[Dennis Nienhüser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104736/#review12931
-----------------------------------------------------------


Looks good on a quick sight, I'll give it a more thorough test in the next days.


src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/104736/#comment10061>

    const QByteArray &line (faster)



src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp
<http://git.reviewboard.kde.org/r/104736/#comment10062>

    m_socket must be initialized to 0, otherwise the dtor and isInitialized won't work correctly


- Dennis Nienhüser


On April 26, 2012, 2:02 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104736/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 2:02 p.m.)
> 
> 
> Review request for Marble.
> 
> 
> Description
> -------
> 
> When selecting the plugin in the current location panel it starts listen on an udp socket (localhost:5500), which is the default port flightgear uses for exporting map display information. The data send to this port is build as gps data in nmea format.
> 
> The plugin depends on the mnea library http://nmea.sourceforge.net/. The presence of this library is checked on configure time. Building of this plugins only happens when this library is available. 
> 
> On windows the nmea library has been added to the KDE on windows build enviroment. 
> 
> 
> This addresses bug 298785.
>     http://bugs.kde.org/show_bug.cgi?id=298785
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d6466aa 
>   cmake/modules/Findnmealib.cmake PRE-CREATION 
>   src/plugins/positionprovider/CMakeLists.txt bebe774 
>   src/plugins/positionprovider/flightgear/CMakeLists.txt PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.h PRE-CREATION 
>   src/plugins/positionprovider/flightgear/FlightGearPositionProviderPlugin.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104736/diff/
> 
> 
> Testing
> -------
> 
> succesfull build and tested on windows 7 with msvc 2010 in debug and release mode
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120426/34c4f5aa/attachment.html>