[Marble-devel] Review Request: The proposed patch is to add tunnels, bridges and route-subways in the rendering.

Bernhard Beschow bbeschow at cs.tu-berlin.de
Tue Apr 17 22:48:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104496/#review12620
-----------------------------------------------------------


Could you please (1) explain a bit more what your patch does and (2) create a proper diff for your patch? (2) would allow us to apply your changes much easier and it would also improve communication since we'd be able to comment on every changed line. Thanks in advance!

- Bernhard Beschow


On April 6, 2012, 9:56 a.m., Rahul Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104496/
> -----------------------------------------------------------
> 
> (Updated April 6, 2012, 9:56 a.m.)
> 
> 
> Review request for Marble and Torsten Rahn.
> 
> 
> Description
> -------
> 
> The proposed patch is to add tunnels, bridges and route-subways in the rendering.
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/104496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20120417/c3e3ccc3/attachment.html>


More information about the Marble-devel mailing list