[Marble-devel] Review Request:

[Niko Sams]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102637/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

This patch adds an AltidudeModel that can be used to get the altitude/elevation of a coordinate. The altitude-profile plugin uses that to generate a profile for a route and calculate some statistics.
The altitude-profile will be replaced/merged with elevationprofile plugin that was developed in parallel.

The other important part are the tiles. I used the existing TileCreator, refactored it to be more flexible and made a binary that creates the needed png tiles from the nasa srtm files. This takes a loong time, just as the upload to files.kde.org that is still running.

Please review my changes especially also those to TileCreator.
To review this you can also use the altitude branch in the marble repository; that contains full history (which might be useful)

In the attached screenshot you can see the altitude-profile float widget (red line) and the elevationprofile float widget (black line) - not included in this request.


Diffs
-----

  data/CMakeLists.txt 6f16a74 
  data/maps/earth/srtm2/0/000000/000000_000000.png PRE-CREATION 
  data/maps/earth/srtm2/0/000000/000000_000001.png PRE-CREATION 
  data/maps/earth/srtm2/srtm2.dgml PRE-CREATION 
  src/lib/AltitudeModel.h PRE-CREATION 
  src/lib/AltitudeModel.cpp PRE-CREATION 
  src/lib/CMakeLists.txt 328db8f 
  src/lib/MarbleModel.h e52536c 
  src/lib/MarbleModel.cpp 0a8a882 
  src/lib/TileCreator.h 5b58158 
  src/lib/TileCreator.cpp 0ffa155 
  src/lib/routing/AlternativeRoutesModel.h 945a745 
  src/plugins/render/CMakeLists.txt 37075b3 
  src/plugins/render/altitude-profile/AltitudeProfile.h PRE-CREATION 
  src/plugins/render/altitude-profile/AltitudeProfile.cpp PRE-CREATION 
  src/plugins/render/altitude-profile/CMakeLists.txt PRE-CREATION 
  src/plugins/render/altitude-profile/PlotPoint.h PRE-CREATION 
  src/plugins/render/altitude-profile/PlotPoint.cpp PRE-CREATION 
  src/plugins/render/altitude-profile/PlotWidget.h PRE-CREATION 
  src/plugins/render/altitude-profile/PlotWidget.cpp PRE-CREATION 
  tools/tilecreator-srtm2/CMakeLists.txt PRE-CREATION 
  tools/tilecreator-srtm2/main.cpp PRE-CREATION 
  tools/tilecreator-srtm2/tccore.h PRE-CREATION 
  tools/tilecreator-srtm2/tccore.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102637/diff


Testing
-------


Screenshots
-----------

altitude profile in action
  http://git.reviewboard.kde.org/r/102637/s/263/


Thanks,

Niko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110916/eae34bb7/attachment-0001.html>