[Marble-devel] Review Request: Add missing KmlIconStyleTagWriter

[Javier Becerra Elcinto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102611/
-----------------------------------------------------------

Review request for Marble.


Summary
-------

Created missing KmlIconStyleTagWriter.cpp and KmlIconStyleTagWriter.h 
Added a convenience function GeoDataIconStyle::iconPath() required by KmlIconStyleTagWriter.
When a placemark is created with a QPixmap instead of a filename, the icon is ignored when writing to file (KML does not seem to support icons embedded in kml files, it only allows for hrefs to be used to define them, maybe there is a way to include the binary image somewhere in the document and reference it from the href in the Icon tag?).


Diffs
-----

  src/lib/geodata/data/GeoDataIconStyle.h 87ec5e1 
  src/lib/geodata/data/GeoDataIconStyle.cpp 15a2597 
  src/lib/geodata/writers/kml/KmlIconStyleTagWriter.h PRE-CREATION 
  src/lib/geodata/writers/kml/KmlIconStyleTagWriter.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102611/diff


Testing
-------


Thanks,

Javier

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/marble-devel/attachments/20110914/3806589e/attachment-0001.html>